Fixing Molecular orbital rendering with Flying Edges #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Perminder <[email protected]>
|
I can confirm this fixes the bug on anything I've tried. I'll do some more testing tomorrow to be sure. |
Sure.. Do let me know if anything still breaks. |
|
Here are the build results |
|
This pull request has been mentioned on Avogadro Discussion. There might be relevant details there: https://discuss.avogadro.cc/t/december-2024-live-updates/6609/1 |
|
Looks good in further testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the second mesh, we were still using old triangles array from the first mesh.
When we switch to the second mesh, we also fetch its triangles by calling
triangles2 = mesh->triangles();. This ensures that the second mesh is rendered with its own vertices, normals, and triangle indices, not the first mesh's data.Here's the result:
