front: add track column to timestops table

[Synar]

Close #9526

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 7.36196% with 151 lines in your changes missing coverage. Please review.

Project coverage is 38.14%. Comparing base (a9e4a9b) to head (2e4b902).
Report is 7 commits behind head on dev.

Files with missing lines	Patch %	Lines
...src/modules/timesStops/hooks/useOutputTableData.ts	0.00%	40 Missing and 1 partial ⚠️
...operationalStudies/hooks/useCachedTrackSections.ts	12.50%	28 Missing ⚠️
front/src/modules/timesStops/TimesStopsInput.tsx	0.00%	21 Missing ⚠️
...ns/operationalStudies/hooks/useScenarioContext.tsx	22.72%	17 Missing ⚠️
...c/modules/timesStops/hooks/useTimeStopsColumns.tsx	0.00%	12 Missing ⚠️
...ationResult/hooks/useFormattedOperationalPoints.ts	0.00%	8 Missing ⚠️
front/src/modules/pathfinding/utils.ts	0.00%	7 Missing ⚠️
front/src/modules/timesStops/TimesStops.tsx	0.00%	7 Missing ⚠️
...s/simulationResult/SimulationResultExport/utils.ts	0.00%	3 Missing ⚠️
...applications/operationalStudies/views/Scenario.tsx	0.00%	2 Missing ⚠️
... and 4 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #9614      +/-   ##
==========================================
- Coverage   38.18%   38.14%   -0.04%     
==========================================
  Files         996      998       +2     
  Lines       92033    92118      +85     
  Branches     1192     1192              
==========================================
  Hits        35143    35143              
- Misses      56434    56519      +85     
  Partials      456      456              

Flag	Coverage Δ
editoast	73.31% <ø> (-0.03%)	⬇️
front	20.16% <7.36%> (-0.02%)	⬇️
gateway	2.18% <ø> (ø)
osrdyne	3.28% <ø> (ø)
railjson_generator	87.49% <ø> (ø)
tests	87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Synar]

(Update to the tests coming soon ^^)

[Synar]

@Yohh je t'ajoute en review juste pour le mini changement de test

[Akctarus]

Tested, perhaps we could add a little padding-right for long track names to match the padding-left:

Apart from that, LGTM!

[Synar]

Thanks! I extended the width a bit.

[Synar]

2 notes : - conflict with incoming #9642 to fix, probably by replacing the formatSuggestedOperationalPoints call by a formatSuggestedOperationalPointsWithTrackName call in use output table data

• we should probably cache the tracks information, possibly as a context in the scenario page

[Synar]

Todo :

• add tracksectionsLoading state to hook and context

[SharglutDev]

Thank you for the last changes ! Left some comments, they are totally debatable

[Synar]

2 new fixup, the second one is the change from usestate to useref for the content of the cache, to avoid dependency loops and useless renders

[Synar]

Clara asked me to ping all maintainers about adding context to the scenario, so here : @kmer2016 @emersion @SharglutDev @clarani @Math-R . Sorry for the inconvenience, hope I didn't forget anyone ^^

[SharglutDev]

Lgtm and tested for me. Waiting for at least a 2nd maintainer approval for the context subject :) (@clarani)

[kmer2016]

Nice job ! Just a small suggestion

[emersion]

Overall the context approach sounds good to me :)

[Maymanaf]

Nice PR! The changes look good for the minor update in the e2e test.

If possible, could you expand the scope to include a check for the track values? If adding it now isn't feasible, please create an issue and assign it to me for follow-up later.

Thanks! 😊

[Synar]

Nice PR! The changes look good for the minor update in the e2e test.

If possible, could you expand the scope to include a check for the track values? If adding it now isn't feasible, please create an issue and assign it to me for follow-up later.

Thanks! 😊

Done!

[clarani]

LGTM ✅

[Maymanaf]

LGTM for e2e tests ✅