Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: update e2e study date check #9913

Merged
merged 1 commit into from
Dec 3, 2024
Merged

front: update e2e study date check #9913

merged 1 commit into from
Dec 3, 2024

Conversation

Maymanaf
Copy link
Contributor

@Maymanaf Maymanaf commented Dec 2, 2024

The test is failing as the check didn't account for the french language.

Expected string: "2 dec 2024"
Received string: "2 déc 2024"

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 2, 2024
@Maymanaf Maymanaf force-pushed the aba/e2e-fix-date-check branch from a189a6f to 1ac1df6 Compare December 2, 2024 16:15
@Maymanaf Maymanaf marked this pull request as ready for review December 2, 2024 16:15
@Maymanaf Maymanaf requested a review from a team as a code owner December 2, 2024 16:15
@Maymanaf Maymanaf requested review from SharglutDev and Yohh December 2, 2024 16:31
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested. Is it why lots or PR's are failing in merge queue right now ?

Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Maymanaf Maymanaf added this pull request to the merge queue Dec 3, 2024
Merged via the queue into dev with commit 83934dc Dec 3, 2024
27 checks passed
@Maymanaf Maymanaf deleted the aba/e2e-fix-date-check branch December 3, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants