Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #2 #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skinkie
Copy link

@skinkie skinkie commented Jun 20, 2014

Doing a pull request from Thalys is the best investment in time and money.

I fixed the missing StreetNetworkParams, and substituted StreetNetworkMode for the current string.

Please add some comments to the fields though.

optional double car_speed = 7;
optional double bss_speed = 9;
// Speed sounds ambigious, do you mean:
// 1) slower speak because the bicycle is fragile

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the speed depends on the user and the bike (since the bss's bike are generaly heavier than a user's the speed might be different)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants