feat/lang_utils #85
Merged
feat/lang_utils #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helper utils to get valid languages based on mycroft.conf unified in a single util since it's starting to get used in a few different places also adds helper to turn a 2-letter lang code into a full 4-letter BCP lang code, taking into account dialect preferences from mycroft.conf
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #85 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 10
Lines ? 822
Branches ? 0
=====================================
Hits ? 0
Misses ? 822
Partials ? 0 ☔ View full report in Codecov by Sentry. |
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Dec 7, 2023
companion to OpenVoiceOS/ovos-config#85 fixes #380
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Dec 15, 2023
* fix/2-letter-langcode-handling companion to OpenVoiceOS/ovos-config#85 fixes #380 * Update requirements.txt
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helper utils to get valid languages based on mycroft.conf
unified in a single util since it's starting to get used in a few different places
also adds helper to turn a 2-letter lang code into a full 4-letter BCP lang code, taking into account dialect preferences from mycroft.conf