Skip to content

Commit

Permalink
fix(ai-server): adjust to python 3.12.X instead of 3.12.4 (#16356)
Browse files Browse the repository at this point in the history
# Overview

> **Use the latest patch version of python 3.12 for AI server**

## Test Plan and Hands on Testing

1. Tested locally with no issues.
2. Once this PR is merged to edge the staging deployment will happen.
Validate there.
3. Once staging is validated push a tag to trigger the production build.

## Risk assessment

- Low, patch versions of python should introduce no breaking changes,
only bug fixes and security updates.
- Our continuous deployment to staging on edge merge, local builds of
the container, and local dev should expose any issues.
  • Loading branch information
y3rsh authored Sep 25, 2024
1 parent 42aaeba commit 7d153ad
Show file tree
Hide file tree
Showing 6 changed files with 1,210 additions and 1,082 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/opentrons-ai-server-lint-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Setup Python
uses: 'actions/setup-python@v5'
with:
python-version: '3.12.4'
python-version: '3.12'
cache: 'pipenv'
cache-dependency-path: opentrons-ai-server/Pipfile.lock
- name: Setup
Expand Down
2 changes: 1 addition & 1 deletion opentrons-ai-server/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM --platform=linux/amd64 python:3.12.4-slim
FROM --platform=linux/amd64 python:3.12-slim

ENV PYTHONUNBUFFERED True
ENV DOCKER_RUNNING True
Expand Down
2 changes: 1 addition & 1 deletion opentrons-ai-server/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ install-pipenv:

.PHONY: setup
setup: install-pipenv
python -m pipenv install --dev --python 3.12.4
python -m pipenv install --dev --python 3.12

.PHONY: teardown
teardown:
Expand Down
1 change: 0 additions & 1 deletion opentrons-ai-server/Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,3 @@ types-beautifulsoup4 = "*"

[requires]
python_version = "3.12"
python_full_version = "3.12.4"
Loading

0 comments on commit 7d153ad

Please sign in to comment.