chore(docs): touch up trash bin line on docs homepage #14492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14492 +/- ##
==========================================
- Coverage 67.79% 67.79% -0.01%
==========================================
Files 2518 2518
Lines 72004 72003 -1
Branches 9244 9244
==========================================
- Hits 48815 48814 -1
Misses 20987 20987
Partials 2202 2202
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ecormany
requested review from
anuwrag and
jwwojak
and removed request for
a team
jwwojak
reviewed
Feb 14, 2024
api/docs/v2/index.rst
Outdated
| plate = protocol.load_labware( | ||
| "corning_96_wellplate_360ul_flat", location="D1" | ||
| ) | ||
| tiprack = protocol.load_labware( | ||
| "opentrons_flex_96_tiprack_200ul", location="D2" | ||
| ) | ||
| trash = protocol.load_trash_bin("A3") |
There was a problem hiding this comment.
do we need to use a named location to keep things uniform with the rest of the sample code?
protocol.load_trash_bin(location = "A3")
jwwojak
reviewed
Feb 14, 2024
sfoster1
approved these changes
Feb 14, 2024
jwwojak
reviewed
Feb 15, 2024
andySigler
pushed a commit
that referenced
this pull request
Feb 15, 2024
* revert 2.17 changes * fix trash line on homepage * named location arg
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
* revert 2.17 changes * fix trash line on homepage * named location arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow up to #14455. Fixes syntax and makes the code match the order on the Protocol Examples page.
Also does some housekeeping to set up a feature branch for docs content tied to the PAPI 2.17 release. That will also allow for this change to be deployed immediately.
Test Plan
Changelog
trashline and properly indent.Review requests
the whole branch management plan seems sound?
Risk assessment
v low. deleting some docs content but it should be preserved in other branches.