Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): touch up trash bin line on docs homepage #14492

Merged
merged 3 commits into from
Feb 15, 2024
Merged

chore(docs): touch up trash bin line on docs homepage #14492

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e1696f
revert 2.17 changes
ecormany Feb 14, 2024
2ea948b
fix trash line on homepage
ecormany Feb 14, 2024
82786c1
named location arg
ecormany Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/docs/v2/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,13 @@ For example, if we wanted to transfer liquid from well A1 to well B1 on a plate,
# protocol run function
def run(protocol: protocol_api.ProtocolContext):
# labware
trash = protocol.load_trash_bin("A3")
plate = protocol.load_labware(
"corning_96_wellplate_360ul_flat", location="D1"
)
tiprack = protocol.load_labware(
"opentrons_flex_96_tiprack_200ul", location="D2"
)
trash = protocol.load_trash_bin("A3")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to use a named location to keep things uniform with the rest of the sample code?

protocol.load_trash_bin(location = "A3")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, we could


# pipettes
left_pipette = protocol.load_instrument(
Expand Down
5 changes: 0 additions & 5 deletions api/docs/v2/versioning.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,6 @@ This table lists the correspondence between Protocol API versions and robot soft
Changes in API Versions
=======================

Version 2.17
------------

- :py:meth:`.dispense` will now raise an error if you try to dispense more than is available.

Version 2.16
------------

Expand Down
4 changes: 0 additions & 4 deletions api/src/opentrons/protocol_api/instrument_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,10 +345,6 @@ def dispense( # noqa: C901

.. versionchanged:: 2.15
Added the ``push_out`` parameter.

.. versionchanged:: 2.17
Now raises an exception if you try to dispense more than is available.
Previously, it would silently clamp.
"""
if self.api_version < APIVersion(2, 15) and push_out:
raise APIVersionError(
Expand Down
Loading