fix(test): snapshot renaming #15038
fix(test): snapshot renaming #15038
Conversation
There was a problem hiding this comment.
👀 on this
seems a big change
There was a problem hiding this comment.
This is an expected change following #15002. We now use the latest pipette version's flow rates as the default rates during protocol analysis/ simulation.
For this particular protocol, the P50 pipette's default flow rate has changed from 8 to 35 uL/sec, default dispense changed from 8 to 57 uL/sec, etc
...snapshot[1960aa7a4c][Flex_S_v2_15_P1000M_P50M_GRIP_HS_MB_TC_TM_IlluminaDNAEnrichmentv4].json
Show resolved
Hide resolved
There was a problem hiding this comment.
@y3rsh You resolved this thread—this is expected? Out of curiosity, do you know why?
…alysis_snapshot[df86e64c63][OT2_X_v2_16_NO_PIPETTES_TC_verifyThermocyclerLoadedSlots].json
There was a problem hiding this comment.
This all looks reasonable to me, though it's difficult to be exhaustive because of the assorted semantic changes that are happening concurrently with the renames.
This is reaffirming for me that we should run these snapshot tests on each PR, to spread the work of verifying them and keep the diffs tied to the underlying changes that caused them, but I'm curious if you have any alternative solutions.
Yes. With the better error handling and organization in place, part 3 or 4 of my current effort is to get these running on PR. |
# Cleanup snapshots
- Given the new protocol organization and naming
- delete all the snapshots of the old naming `find -type f ! \( -name
'*_S_*' -o -name '*_X_*' \) -exec rm {} +`
- `make build-opentrons-analysis` (default on edge)
- ` make snapshot-test-update`
- find old snapshots and delete
- Given the new protocol organization and naming
- delete all the snapshots of the old naming `find -type f ! \( -name
'*_S_*' -o -name '*_X_*' \) -exec rm {} +`
- `make build-opentrons-analysis` (default on edge)
- ` make snapshot-test-update`
- find old snapshots and delete
Cleanup snapshots
find -type f ! \( -name '*_S_*' -o -name '*_X_*' \) -exec rm {} +make build-opentrons-analysis(default on edge)make snapshot-test-update