-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hail batch + translator base refactor #70
base: master
Are you sure you want to change the base?
Conversation
Maybe link to https://hail.is/docs/batch/index.html and/or other relevant sites for context? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…anis-core into add-hail-batch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @illusional , the tests failed because anis_assistant in master branch is still calling
Can you look into what changes we should make in janis_assistant to fix this error? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relies on #69 being merged, that will cleanup the commit history, otherwise the short history:
Summary:
translate_workflow
->translate_workflow_internal
namedtuple
for naming output type of this methodtranslate
->translate_workflow
@staticmethods
into@classmethods
for consistencyAnd added the Hail Batch translator.