Nacho/remove kitti from core library #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 12, 2024
Put it in python bindings, that is the only place where is actually used
nachovizzo
force-pushed
the
nacho/remove_kitti_from_core_library
branch
from
d8ae526 to
8951c5d
Compare
nachovizzo
changed the base branch from
tiziano/voxel_utils_style_change
to
main
|
Finally this tumor is out, thanks bruda |
|
Fixing conflicts now |
tizianoGuadagnino
previously approved these changes
Jul 22, 2024
nachovizzo
dismissed stale reviews from tizianoGuadagnino and benemer
via
74988df
benemer
approved these changes
Jul 22, 2024
tizianoGuadagnino
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove KITTI scan correction from the core library
I'd love to get rid of the KITTI correction step from our CORE library, with the new changes in the voxelization, this makes more sense than ever
I also removed the tbb from the correction step, and the runtime was not impacted, and I don't care honestly.