Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nacho/new core propossal #370

Closed
wants to merge 26 commits into from
Closed

Nacho/new core propossal #370

wants to merge 26 commits into from

Conversation

nachovizzo
Copy link
Collaborator

@nachovizzo nachovizzo commented Jul 12, 2024

A long waited PR, refactor the system to be at least filesystem consistent

Follow up of #369

C++ tree

cpp
└── kiss_icp
    ├── core
    │   ├── CMakeLists.txt
    │   ├── Preprocessing.cpp
    │   ├── Preprocessing.hpp
    │   ├── Registration.cpp
    │   ├── Registration.hpp
    │   ├── Threshold.cpp
    │   ├── Threshold.hpp
    │   ├── VoxelHashMap.cpp
    │   ├── VoxelHashMap.hpp
    │   ├── Voxelization.cpp
    │   └── Voxelization.hpp
    ├── metrics
    │   ├── CMakeLists.txt
    │   ├── Metrics.cpp
    │   └── Metrics.hpp
    └── pipeline
        ├── CMakeLists.txt
        ├── KissICP.cpp
        └── KissICP.hpp

Python tree

python
├── kiss_icp
│   ├── core
│   │   ├── __init__.py
│   │   ├── preprocess.py
│   │   ├── registration.py
│   │   ├── threshold.py
│   │   ├── voxel_hash_map.py
│   │   └── voxelization.py
│   ├── metrics
│   │   ├── __init__.py
│   │   └── metrics.py
│   ├── pipeline
│   │   ├── __init__.py
│   │   └── kiss_icp.py

questions

  • VoxelHashMap.cpp -> Mapping.cpp. I guess no, so I reanmed the python one

@nachovizzo nachovizzo force-pushed the nacho/remove_kitti_from_core_library branch from d8ae526 to 8951c5d Compare July 20, 2024 08:48
Base automatically changed from nacho/remove_kitti_from_core_library to main July 24, 2024 07:31
@nachovizzo
Copy link
Collaborator Author

Closing this as it already conflicts with main branch

@nachovizzo nachovizzo closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants