ci: Prohibit overriding /New on /atom subtypes #27261
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This PR adds a check prohibiting subtypes of /atom, /turf, /obj, and /mob from overriding /New. It will be in draft status while this list is burned down, and then added to CI.
Why It's Good For The Game
All of these uses of /New should have been gone long ago. /Initialize is the expected way to handle atom initialization. We can't control the timing of /New, we can't prevent atoms from going off and
spawn
ing in /New, and as far as I can tell we might be able to get rid of the DMM preloader entirely if we don't have to compensate for atoms doing unnecessary things in /New. It's long past time to clean these out and prohibit this.There's only two instances of
INITIALIZE_IMMEDIATE
which calls /Initialize in /New, and since that's a macro, this check ignores it.Images of changes
Testing
Ran CI.
Declaration
Changelog
NPFC