Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Prohibit overriding /New on /atom subtypes #27261

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

warriorstar-orion
Copy link
Contributor

What Does This PR Do

This PR adds a check prohibiting subtypes of /atom, /turf, /obj, and /mob from overriding /New. It will be in draft status while this list is burned down, and then added to CI.

Why It's Good For The Game

All of these uses of /New should have been gone long ago. /Initialize is the expected way to handle atom initialization. We can't control the timing of /New, we can't prevent atoms from going off and spawning in /New, and as far as I can tell we might be able to get rid of the DMM preloader entirely if we don't have to compensate for atoms doing unnecessary things in /New. It's long past time to clean these out and prohibit this.

There's only two instances of INITIALIZE_IMMEDIATE which calls /Initialize in /New, and since that's a macro, this check ignores it.

Images of changes

2024_11_01__23_50_43__Comparing ParadiseSS13_master warriorstar-orion_ci_atom_new_overrides · Paradi

Testing

Ran CI.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Nov 2, 2024
@AffectedArc07
Copy link
Member

Finally, inner peace.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Nov 5, 2024
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Nov 6, 2024
Copy link
Contributor

This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.

@github-actions github-actions bot added the Stale This PR has been left inactive and requires an update. label Nov 21, 2024
@github-actions github-actions bot removed Stale This PR has been left inactive and requires an update. Merge Conflict This PR is merge conflicted labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants