Replace *big.Rat with shopspring decimal.Decimal #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
rat-poison
branch
8 times, most recently
from
45fe520 to
d874a66
Compare
Amogh-Bharadwaj
approved these changes
Mar 16, 2024
Rational numbers are awkward decimals, using a decimal type for decimal data has a few benefits: 1. perf-wise decimal representation is a *big.Int & an int32 exponent, instead of 2 *big.Ints 2. decimal has obvious conversion to/from decimal strings, whereas *big.Rat can be wonky going through FloatString 3. with scripting most people will want to use their decimal values as decimals, not decimal rationals Fixes #1175
serprex
force-pushed
the
rat-poison
branch
3 times, most recently
from
a8bc0b6 to
f804e63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rational numbers are awkward decimals,
using a decimal type for decimal data has a few benefits:
whereas *big.Rat can be wonky going through FloatString
A side effect of this is that we now convert NaN/inf/-inf numerics to null. Previously they'd all get converted to NaN. This would only be usable for pg<->pg, only causing trouble with other peers, & even then we'd want inf/-inf to be properly translated
Fixes #1175