Experiment: replace testify suite.Suite with our own that supports parallelism #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
faster-flow-ci
branch
3 times, most recently
from
46dcd26 to
949efa8
Compare
serprex
force-pushed
the
faster-flow-ci
branch
from
ddb731e to
e928fa1
Compare
|
So sharing suite was failing because it'd read 20 rows when expecting 10, moved to suite-per-test, but need postgres schema cleanup etc to be per-suite |
|
Close in favor of #640 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while we run the packages in parallel, all of that time is stuck on bigquery/snowflake, limiting parallelism to 2
Running testify suites in parallel is trouble: stretchr/testify#187
So remove suite & run tests in parallel
For now testing snowflake. Doesn't include delta test