Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: replace testify suite.Suite with our own that supports parallelism #629

Closed
wants to merge 9 commits into from
Closed

Experiment: replace testify suite.Suite with our own that supports parallelism #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
11326d7
Experiment: replace testify suite.Suite with our own that supports pa…
serprex Nov 8, 2023
4062d4b
investigating why rows aren't same, probably some thread safety issue
serprex Nov 8, 2023
6ed54e8
sanity check: does it work without t.Parallel?
serprex Nov 8, 2023
e928fa1
test: does suite-per-test pass?
serprex Nov 9, 2023
19f6780
Try move parallel test logic into generic function
serprex Nov 9, 2023
d556218
Pointers & generics & errors oh my
serprex Nov 9, 2023
4052449
Ideally it'd be RunSuite[T] instead of RunSuite[*T] but pointer recei…
serprex Nov 9, 2023
e5555d1
Tests don't always have _
serprex Nov 9, 2023
061aa33
vary schema name by test
serprex Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/flow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:

- name: run tests
run: |
gotestsum --format testname -- -p 4 ./... -timeout 2400s
gotestsum --format testname -- -p 4 ./e2e/snowflake/... -timeout 2400s
working-directory: ./flow
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
Expand Down
Loading