S3 Peer UI #668
Merged
S3 Peer UI #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amogh-Bharadwaj
force-pushed
the
ui-s3-peer
branch
from
154c216 to
02ca098
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
flow/connectors/s3/s3.go
Outdated
| @@ -85,6 +93,48 @@ func (c *S3Connector) Close() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func ValidCheck(s3Client *s3.S3, bucketUrl string, metadataDB *metadataStore.PostgresMetadataStore) error { | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
ST1003: func parameter bucketUrl should be bucketURL (stylecheck)
Amogh-Bharadwaj
force-pushed
the
ui-s3-peer
branch
from
fa11e9f to
44ab4c4
Compare
Amogh-Bharadwaj
force-pushed
the
ui-s3-peer
branch
from
70163ff to
afdef01
Compare
iskakaushik
reviewed
Nov 16, 2023
flow/connectors/s3/s3.go
Outdated
| return fmt.Errorf("failed to list buckets: %w", listErr) | ||
| } | ||
|
|
||
| reader := strings.NewReader("hello world") |
There was a problem hiding this comment.
put something like a timestamp string
iskakaushik
reviewed
Nov 16, 2023
flow/connectors/s3/s3.go
Outdated
| bucketName := aws.String(bucketPrefix.Bucket) | ||
| _, putErr := s3Client.PutObject(&s3.PutObjectInput{ | ||
| Bucket: bucketName, | ||
| Key: aws.String("peerdb_check"), |
There was a problem hiding this comment.
make this a const in the file and call it __peerdb_check
flow/connectors/s3/s3.go
Outdated
| "github.com/aws/aws-sdk-go/service/s3" | ||
| log "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| const ( | ||
| CHECK_OBJECT_KEY = "peerdb_check" |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
ST1003: should not use ALL_CAPS in Go names; use CamelCase instead (stylecheck)
Amogh-Bharadwaj
force-pushed
the
ui-s3-peer
branch
from
fa323e6 to
b1db091
Compare
Amogh-Bharadwaj
force-pushed
the
ui-s3-peer
branch
from
b1db091 to
4b831cd
Compare
iskakaushik
reviewed
Nov 17, 2023
Comment on lines
+55
to
+62
| metadataDb: { | ||
| host: '', | ||
| port: 5432, | ||
| user: 'postgres', | ||
| password: '', | ||
| database: 'postgres', | ||
| transactionSnapshot: '', | ||
| }, |
There was a problem hiding this comment.
Don't expose metadata db to the user, just use catalog.
iskakaushik
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RegionandRole ARNfields will not be shown as they have fixed values for GCS