Fix e2e.RequireEqualRecordBatches #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
commented
Jan 3, 2024
| @@ -65,3 +65,41 @@ func CheckQRecordEquality(t *testing.T, q model.QRecord, other model.QRecord) bo | |||
|
|
|||
| return true | |||
| } | |||
|
|
|||
| // Equals checks if two QRecordBatches are identical. | |||
| func CheckEqualRecordBatches(t *testing.T, q *model.QRecordBatch, other *model.QRecordBatch) bool { | |||
There was a problem hiding this comment.
Maintaining the bool returning version as I intend to move our tests towards WaitFor which will want plenty of boolean utility functions
Function was returning bool while callers expect testify/require semantics
serprex
force-pushed
the
fix-require-equal-record-batches
branch
from
6bbeff0 to
2cfcd10
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
lint seems to be a false positive, doesn't show up locally |
We were never actually checking the geo column values in snowflake qrep. This PR aims to fix that and also a lint Fixes #973
serprex
added a commit
that referenced
this pull request
Jan 3, 2024
docs: > FailNow must be called from the goroutine running the test or benchmark function, > not from other goroutines created during the test This would cause workflow to hang if it was waiting on goroutine, so introduce helper functions which: 1. Check assertion 2. Log failure & mark test failed 3. Cancel workflow 4. Abort goroutine A followup PR will fix calls to compareTableContents after #967 merges too
Amogh-Bharadwaj
approved these changes
Jan 3, 2024
serprex
added a commit
that referenced
this pull request
Jan 3, 2024
docs: > FailNow must be called from the goroutine running the test or benchmark function, > not from other goroutines created during the test This would cause workflow to hang if it was waiting on goroutine, so introduce helper functions which: 1. Check assertion 2. Log failure & mark test failed 3. Cancel workflow 4. Abort goroutine A followup PR will fix calls to compareTableContents after #967 merges too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced regression in #923
Function was returning bool while callers expect testify/require semantics