WaitFor #980
Merged
WaitFor #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
wait-for
branch
7 times, most recently
from
c4b65d5 to
29a3daa
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This reverts commit ae10042.
Closed
|
b9843c7 passed, but rerunning to check for flakiness |
Amogh-Bharadwaj
approved these changes
Jan 12, 2024
| @@ -216,7 +216,8 @@ func CDCFlowWorkflowWithConfig( | |||
| RetryPolicy: &temporal.RetryPolicy{ | |||
| MaximumAttempts: 20, | |||
| }, | |||
| SearchAttributes: mirrorNameSearch, | |||
| SearchAttributes: mirrorNameSearch, | |||
| WaitForCancellation: true, | |||
There was a problem hiding this comment.
Tested it out with cancelling a few sync flows and it's fine to keep it (or remove it - whichever helps more).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NormalizeFlowCountQueryis stunting implementing decoupled sync/normalize workflows. So replace it withWaitForBesides, I just don't like this
ExitAfterRecordsway of doing thingse2e tests are integration tests: implementation should be treated as a black box as much as possible
Temporal has a bunch of capabilities to mock activities so that we can create unit tests for the more intrusive tests that'd be necessary to raise branch coverage etc
WaitForpresents the ideal mechanism for testing convergent processes: update source, wait for destination to reflect changeIn order to make this change work, however, I needed to use
env.CancelWorkflowafter completing tests since I now want the workflow running indefinitely. It turns out our code doesn't adequately handle cancellation, so implemented that