Code

WaitFor#980

Code

Merged

serprex merged 77 commits intomainPeerDB-io/peerdb:mainfrom wait-forPeerDB-io/peerdb:wait-forCopy head branch name to clipboardJan 12, 2024

+657-631

Commits

Commits on Jan 5, 2024

• WaitFor

  serprex

  committed
  de3c2c4

• debug waitfor

  serprex

  committed
  0379219

• fix test?

  serprex

  committed
  a8e200c

• experiment: workflow only exits when we cancel it

  serprex

  committed
  6677efb

• fix columns

  serprex

  committed
  d84f3f6

• handle cancel in cdc_flow

  serprex

  committed
  454fcb7

• Don't use reflect.DeepEqual

  serprex

  committed
  855e9db

• idea: need to sleep to avoid test ending before slot closed

  serprex

  committed
  c510262

• think activity context needs heartbeat to find out workflow was cancelled

  serprex

  committed
  fa6891c

• theory: need to specify WaitForCancellation:true

  serprex

  committed
  18c3a8d

• hoping to use existing heartbeat

  serprex

  committed
  17a505b

• utils.HeartbeatRoutine: use context.WithCancel

  serprex

  committed
  d01b24e

• Try waiting a long time for cancellation

  serprex

  committed
  8c52d8b

• Wait for activity to cancel in a waitfor loop in teardown

  serprex

  committed
  950e9f4

• Convert rest of e2e/postgres to WaitFor

  serprex

  committed
  6b635f3

• First stab at snowflake

  serprex

  committed
  46f9d28

• log cancel

  serprex

  committed
  3dd64e2

• -1

  serprex

  committed
  68cdc87

• compare schema helper, more logging

  serprex

  committed
  6a92239

• fix up expected schema

  serprex

  committed
  b95a132

• fix comparisons

  serprex

  committed
  6f591db

• don't need waitgroup

  serprex

  committed
  cd620b9

• rest of snowflake no longer using normalize flow count

  serprex

  committed
  d47371a

• remove env.AssertExpectations

  serprex

  committed
  448f9fe

• try fixing soft delete mixup

  serprex

  committed
  028d0fd

• clean up non longer needed cmpTableName

  serprex

  committed
  e574110

• equaltables already handles schema

  serprex

  committed
  d9b68ed

• more tablename cleanup

  serprex

  committed
  86ca8b9

• fix softdel_iad, convert mixedcase

  serprex

  committed
  758b587

• more table name fixing

  serprex

  committed
  fbcc64c

• fix error reporting, fix flow names

  serprex

  committed
  c1ddff7

• remove no longer used parameter

  serprex

  committed
  1b989fa

• fix flowjobname

  serprex

  committed
  e6c9a27

• fix missed waitfor fix

  serprex

  committed
  544f59c

Commits on Jan 6, 2024

• more fix

  serprex

  committed
  12cbe0a

• Merge remote-tracking branch 'origin/main' into wait-for

  serprex

  committed
  39dcf17

• bq

  serprex

  committed
  53a181d

• fix sf exclusion

  serprex

  committed
  6809ab3

• more helper, missed a CancelWorkflow

  serprex

  committed
  d88f76d

• improve error messages causing test failures

  serprex

  committed
  8eae927

• fixes

  serprex

  committed
  d7c329a

• column exclusion: include checking c1. debug logging this last test

  serprex

  committed
  a9ced64

• remove datasetName from bqhelper

  serprex

  committed
  a64df48

• more debug

  serprex

  committed
  3b28eff

• fix

  serprex

  committed
  7897009

• more logging

  serprex

  committed
  e435887

• err != nil

  serprex

  committed
  1ab2f23

• I've managed to once again burn an hour of my time over != vs ==

  serprex

  committed
  cafacfd

• remove leftover logging

  serprex

  committed
  4af0d01

• reduce noise from waitfor

  serprex

  committed
  aea6c65

• Merge remote-tracking branch 'origin/main' into wait-for

  serprex

  committed
  9a3d50d

• 2 minute timeout

  serprex

  committed
  a20f178

• skip 5 second sleep at start of SetupCDCFlowStatusQuery

  serprex

  committed
  d9ca763

• log count

  serprex

  committed
  2250165

• Merge remote-tracking branch 'origin/main' into wait-for

  serprex

  committed
  8a696b0

• cleanup code, move cdc timeout into code, raise to 30, fix teardown

  serprex

  committed
  a77938b

• test reverting WaitForCancellation: true

  serprex

  committed
  ae10042

• fix type errors

  serprex

  committed
  6b783ff

• adjust timeouts, refactor WaitFuncSchema into WaitForSchema

  serprex

  committed
  c95180e

• Revert "test reverting WaitForCancellation: true"

  Show description for 2ea6dbd
  serprex

  committed
  2ea6dbd

• 30->15, raise pg timeout to 2m

  serprex

  committed
  4056b62

• not sure why this delete is finnicky

  serprex

  committed
  4ce1f80

• remove logging, move count check out of wait for

  serprex

  committed
  21fd480

Commits on Jan 7, 2024

• Merge branch 'main' into wait-for

  serprex

  authored
  446df16

Commits on Jan 8, 2024

• Merge branch 'main' into wait-for

  serprex

  authored
  6b411e7

Commits on Jan 9, 2024

• Merge branch 'main' into wait-for

  serprex

  authored
  ffaa86f

Commits on Jan 11, 2024

• Merge branch 'main' into wait-for

  serprex

  authored
  79542ac

• Fix 2 tests

  serprex

  committed
  838302a

• Merge remote-tracking branch 'origin/main' into wait-for

  serprex

  committed
  9458da2

• more logging around TearDownPostgres

  serprex

  committed
  9f00855

• replace reviewdog action with official golangci action

  serprex

  committed
  afc9367

Commits on Jan 12, 2024

• Merge remote-tracking branch 'origin/main' into wait-for

  serprex

  committed
  b9843c7

• Increase wait for margins, long term need to make heartbeats not be 2 minutes long

  serprex

  committed
  f9f0d0b

• Merge remote-tracking branch 'origin/main' into wait-for

  serprex

  committed
  54d4bc4

• cleanup SetupCDCFlowStatusQuery control flow

  serprex

  committed
  7ad14d6

• bq is slow

  serprex

  committed
  5b70e27

• Theory: big query isn't slow, we're just getting hung up on caching

  serprex

  committed
  00d0085