HeartbeatRoutine: return context.CancelFunc instead of chan struct{} #997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context.WithCancel
is a bit hairy in its implementation since internally they use a lazily allocatedchan struct{}
themselves, but seems idiomatic to use itHeartbeatRoutine could keep creating its own
chan struct{}
& insteadreturn func() { close(shutdown) }
to keep the same API