Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade com.palantir.baseline:baseline-error-prone 4.145.0 -> 4.182.0 #172

Closed
wants to merge 1 commit into from

Conversation

Picnic-Bot
Copy link
Contributor

@Picnic-Bot Picnic-Bot commented Aug 1, 2022

This PR contains the following updates:

Package Type Update Change
com.palantir.baseline:baseline-error-prone compile minor 4.145.0 -> 4.182.0

Release Notes

palantir/gradle-baseline

v4.182.0

Compare Source

Type Description Link
Improvement Upgrade error-prone to 2.16, removing support for compilation with a jdk-15 target https://github.com/palantir/gradle-baseline/pull/2432

v4.181.0

Compare Source

Type Description Link
Fix Fix ConcurrentModificationExceptions thrown from BaselineNullAway https://github.com/palantir/gradle-baseline/pull/2427

v4.180.0

Compare Source

Type Description Link
Improvement exempt @​link javadoc comment from LineLength check https://github.com/palantir/gradle-baseline/pull/2414

v4.179.0

Compare Source

Type Description Link
Improvement Implement ImmutableMapDuplicateKeyStrategy for obvious map construction. By default we suggest replacing build() with the more descriptive buildOrThrow(), however buildKeepingLast() may be the original intent in some cases. https://github.com/palantir/gradle-baseline/pull/2416

v4.178.0

Compare Source

Type Description Link
Fix Refaster compilation uses exports matching error-prone compilation https://github.com/palantir/gradle-baseline/pull/2407

v4.177.0

Compare Source

Type Description Link
Fix baseline-immutables adds required exports to the java compiler for compatibility with jdk-17+ https://github.com/palantir/gradle-baseline/pull/2406

v4.176.0

Compare Source

Type Description Link
Improvement Error-prone is enabled in idea for uniformity with CLI compilation https://github.com/palantir/gradle-baseline/pull/2405

v4.175.0

Compare Source

Type Description Link
Fix Fix GitHub issues navigation Idea config https://github.com/palantir/gradle-baseline/pull/2403

v4.174.0

Compare Source

Type Description Link
Improvement Allow projects which don't use jdk-15 to resolve latest nullaway https://github.com/palantir/gradle-baseline/pull/2400

v4.173.0

Compare Source

Type Description Link
Fix Nullaway is not enabled in test sources https://github.com/palantir/gradle-baseline/pull/2402

v4.172.0

Compare Source

Automated release, no documented user facing changes

v4.171.0

Compare Source

Type Description Link
Fix com.palantir.baseline-null-away no longer enables the CheckOptionalEmptiness checker by default. https://github.com/palantir/gradle-baseline/pull/2396

v4.170.0

Compare Source

Type Description Link
Fix lazily configure NullAway dependencies to successfully apply NullAway without ordering issues https://github.com/palantir/gradle-baseline/pull/2393

v4.169.0

Compare Source

Type Description Link
Improvement Exclude Spark UnusedStubClass from class uniqueness https://github.com/palantir/gradle-baseline/pull/2390

v4.168.0

Compare Source

Type Description Link
Fix Roll back nullaway+checkerframework for jdk15 support https://github.com/palantir/gradle-baseline/pull/2389

v4.167.0

Compare Source

Automated release, no documented user facing changes

v4.166.0

Compare Source

Automated release, no documented user facing changes

v4.165.0

Compare Source

Type Description Link
Improvement Implement a simple nullaway wrapper plugin com.palantir.baseline-null-away which registers the NullAway check at WARNING. Projects which fail on warnings will require this to pass pre-merge. https://github.com/palantir/gradle-baseline/pull/2382

v4.164.0

Compare Source

Type Description Link
Improvement The CyclomaticComplexity check is now configured with switchBlockAsSingleDecisionPoint. https://github.com/palantir/gradle-baseline/pull/2383

v4.163.0

Compare Source

Type Description Link
Fix Fix interface visibility bug https://github.com/palantir/gradle-baseline/pull/2379

v4.162.0

Compare Source

Type Description Link
Feature java versions preview enhancements

+ support setting preview on a project-by-project basis.
+ Fixes #​2340
+ fails more elegantly if javaVersions is set on not-the-root.
https://github.com/palantir/gradle-baseline/pull/2376

v4.161.0

Compare Source

Type Description Link
Fix Reverts a change introduced to baseline-java-version 4.160.0, which was causing failures on multi-project builds. https://github.com/palantir/gradle-baseline/pull/2369

v4.160.0

Compare Source

Type Description Link
Fix Workaround to IDEA-301084 https://github.com/palantir/gradle-baseline/pull/2368

v4.159.0

Compare Source

Type Description Link
Improvement Add an errorprone check and typed annotation for Javax -> Jakarta

There is a certain class of very problematic cases whereby if you have
a method such as the following:

<br>myJerseyResource.register(/* this is of type Object */ object);<br>

Then if you supply a resource which includes any javax.ws.rs
annotations on it, then those will not be registered if your Jersey
version is 3.x or later (and you'll only find this out at runtime).

The opposite is also true if you try to supply resources annotated
with jakarta.ws.rs to Jersey 2.x.

To address this, this commit attempts to add an errorprone check
which lets implementors add an annotation @ForbidJavax to methods
which have been knowingly migrated to Jakarta EE9 and cannot
accept legacy javax types.
https://github.com/palantir/gradle-baseline/pull/2366

v4.158.0

Compare Source

Type Description Link
Fix Make the checkUnusedDependencies tasks added by baseline-exact-dependencies compatible with Gradle's configure-on-demand feature. https://github.com/palantir/gradle-baseline/pull/2363

v4.157.0

Compare Source

Type Description Link
Improvement Make task initialization lazier in the junit-reports plugin. https://github.com/palantir/gradle-baseline/pull/2364

v4.156.0

Compare Source

Type Description Link
Fix Fix BaselineJavaVersion checkstyle configuration on gradle < 7.5 https://github.com/palantir/gradle-baseline/pull/2360

v4.155.0

Compare Source

Automated release, no documented user facing changes

v4.154.0

Compare Source

Type Description Link
Improvement The JUnits reports plugin is no longer applied by default. Test reports now use the standard output locations from Gradle conventions. https://github.com/palantir/gradle-baseline/pull/2355

v4.153.0

Compare Source

Type Description Link
Fix Set the java launcher for Checkstyle tasks, too https://github.com/palantir/gradle-baseline/pull/2351

v4.152.0

Compare Source

Type Description Link
Feature Add DefaultLocale check

Related to google/error-prone issues 632

Adds a DefaultLocale check that replaces uses of String.toLowerCase() and String.toUpperCase() with the overloads that take a Locale, using Locale.ROOT.
https://github.com/palantir/gradle-baseline/pull/2343

v4.151.0

Compare Source

Type Description Link
Fix javadoc tasks are now properly configured when --enable-preview is used https://github.com/palantir/gradle-baseline/pull/2338

v4.150.0

Compare Source

Type Description Link
Fix Fix the BaselineModuleJvmArgs plugin to once again work as intended in multi-project builds https://github.com/palantir/gradle-baseline/pull/2336

v4.149.0

Compare Source

Type Description Link
Feature Users of the com.palantir.baseline-java-versions plugin can now set javaVersions { distributionTarget = '17_PREVIEW' } to opt-in to Java's --enable-preview flag at compile time. https://github.com/palantir/gradle-baseline/pull/2322

v4.148.0

Compare Source

Type Description Link
Fix Handle safety flow through instanceof pattern matching https://github.com/palantir/gradle-baseline/pull/2331

v4.147.0

Compare Source

Automated release, no documented user facing changes

v4.146.0

Compare Source

Automated release, no documented user facing changes


  • If you want to rebase/retry this PR, click this checkbox.

@Picnic-Bot
Copy link
Contributor Author

Picnic-Bot commented Aug 1, 2022

Suggested commit message:

Upgrade Palantir baseline-error-prone 4.145.0 -> 4.182.0

See:
- https://github.com/palantir/gradle-baseline/releases/tag/4.146.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.147.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.148.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.149.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.150.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.151.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.152.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.153.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.154.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.155.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.156.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.157.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.158.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.159.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.160.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.161.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.162.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.163.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.164.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.165.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.166.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.167.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.168.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.169.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.170.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.171.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.172.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.173.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.174.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.175.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.176.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.177.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.178.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.179.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.180.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.181.0
- https://github.com/palantir/gradle-baseline/releases/tag/4.182.0
- https://github.com/palantir/gradle-baseline/compare/4.145.0...4.182.0

@Picnic-Bot Picnic-Bot force-pushed the renovate/version.palantir-baseline branch 3 times, most recently from da2f534 to a1307d8 Compare August 4, 2022 01:01
@Picnic-Bot Picnic-Bot changed the title Upgrade com.palantir.baseline:baseline-error-prone 4.145.0 -> 4.151.0 Upgrade com.palantir.baseline:baseline-error-prone 4.145.0 -> 4.152.0 Aug 6, 2022
@Picnic-Bot Picnic-Bot force-pushed the renovate/version.palantir-baseline branch 3 times, most recently from 86c8b62 to ae412ce Compare August 8, 2022 01:01
@Picnic-Bot Picnic-Bot changed the title Upgrade com.palantir.baseline:baseline-error-prone 4.145.0 -> 4.152.0 Upgrade com.palantir.baseline:baseline-error-prone 4.145.0 -> 4.153.0 Aug 9, 2022
@Picnic-Bot Picnic-Bot force-pushed the renovate/version.palantir-baseline branch 3 times, most recently from 1bd89e5 to 9363123 Compare August 11, 2022 01:01
@Stephan202
Copy link
Member

Next to the build not (yet?) using this dependency, it turns out that it's also broken in the context of our build. I filed palantir/gradle-baseline#2362. Let's await their response to review whether we should pursue enabling this dependency, or simply drop it.

@Picnic-Bot Picnic-Bot changed the title Upgrade com.palantir.baseline:baseline-error-prone 4.145.0 -> 4.153.0 Upgrade com.palantir.baseline:baseline-error-prone 4.145.0 -> 4.156.0 Aug 12, 2022
@Picnic-Bot Picnic-Bot force-pushed the renovate/version.palantir-baseline branch 2 times, most recently from 19e69f7 to e4c74a4 Compare August 13, 2022 01:01
@rickie
Copy link
Member

rickie commented Aug 17, 2022

Should we add a blocked label? Would be convenient for this PR I'd say.

@Stephan202
Copy link
Member

Sure. (Before we open-source we might want to drop a number of the default labels.)

@rickie rickie added the blocked This blocks either a release or a downstream project label Aug 17, 2022
@Picnic-Bot Picnic-Bot force-pushed the renovate/version.palantir-baseline branch from e4c74a4 to 4b379c0 Compare August 18, 2022 01:03
@Picnic-Bot Picnic-Bot changed the title Upgrade com.palantir.baseline:baseline-error-prone 4.145.0 -> 4.156.0 Upgrade com.palantir.baseline:baseline-error-prone 4.145.0 -> 4.157.0 Aug 19, 2022
@Picnic-Bot Picnic-Bot force-pushed the renovate/version.palantir-baseline branch 6 times, most recently from b6c997d to cabdc7c Compare August 25, 2022 01:01
@Picnic-Bot Picnic-Bot force-pushed the renovate/version.palantir-baseline branch from 9c2323c to ba6a3b0 Compare October 3, 2022 01:01
@Picnic-Bot Picnic-Bot changed the title Upgrade com.palantir.baseline:baseline-error-prone 4.145.0 -> 4.179.0 Upgrade com.palantir.baseline:baseline-error-prone 4.145.0 -> 4.180.0 Oct 4, 2022
@Picnic-Bot Picnic-Bot force-pushed the renovate/version.palantir-baseline branch 4 times, most recently from 13769be to efaa3da Compare October 7, 2022 01:01
@Picnic-Bot Picnic-Bot changed the title Upgrade com.palantir.baseline:baseline-error-prone 4.145.0 -> 4.180.0 Upgrade com.palantir.baseline:baseline-error-prone 4.145.0 -> 4.181.0 Oct 8, 2022
@Picnic-Bot Picnic-Bot force-pushed the renovate/version.palantir-baseline branch 6 times, most recently from 776367c to 78e82ae Compare October 14, 2022 01:01
@Picnic-Bot Picnic-Bot force-pushed the renovate/version.palantir-baseline branch 3 times, most recently from e7d013e to 564ced9 Compare October 21, 2022 01:03
@Picnic-Bot Picnic-Bot changed the title Upgrade com.palantir.baseline:baseline-error-prone 4.145.0 -> 4.181.0 Upgrade com.palantir.baseline:baseline-error-prone 4.145.0 -> 4.182.0 Oct 22, 2022
@Picnic-Bot Picnic-Bot force-pushed the renovate/version.palantir-baseline branch 5 times, most recently from f4abd50 to d38c523 Compare October 26, 2022 08:02
@rickie
Copy link
Member

rickie commented Nov 23, 2022

Ahh because of the keyword "close" in the other PR it is already closed :). Will delete the branch.

@Stephan202 Stephan202 deleted the renovate/version.palantir-baseline branch November 23, 2022 17:56
@Stephan202 Stephan202 removed blocked This blocks either a release or a downstream project pause renovate Stop automatic rebasing labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants