Introduce HasTypeArguments matcher
#644
Conversation
error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/util/MoreMatchers.java
Outdated
Show resolved
Hide resolved
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
1 similar comment
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
oxkitsune
changed the title
MoreMatchers#hasTypeArguments() matcherHasTypeArguments matcher
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
|
Looks good. All 12 mutations in this change were killed.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
| "", | ||
| " Foo positive3() {", | ||
| " // BUG: Diagnostic contains:", | ||
| " return new <List<Object>>Foo(List.of());", |
There was a problem hiding this comment.
There's is probably a better example of this
Stephan202
force-pushed
the
gdejong/has-type-arguments-matcher
branch
from
1655979 to
d0452ab
Compare
|
Looks good. All 12 mutations in this change were killed.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
refaster-support/src/main/java/tech/picnic/errorprone/refaster/matchers/HasTypeArguments.java
Outdated
Show resolved
Hide resolved
| return false; | ||
| } | ||
|
|
||
| return !((ParameterizedTypeTree) classTree.getIdentifier()).getTypeArguments().isEmpty(); |
There was a problem hiding this comment.
We can extract classTree.getIdentifier() as we use it twice.
| "", | ||
| "class A {", | ||
| " Object negative1() {", | ||
| " return alwaysNull();", |
There was a problem hiding this comment.
We can simply use toString() here :)
| "", | ||
| " <E> ImmutableSet<E> positive1() {", | ||
| " // BUG: Diagnostic contains:", | ||
| " return ImmutableSet.<E>builder().build();", |
There was a problem hiding this comment.
We can probably simplify by:
" List<Integer> positive1() {",
" return new ArrayList<Integer>();",
" }",
"",
(Will apply this tomorrow when I get back to this.
|
Kudos, SonarCloud Quality Gate passed! |
|
Looks good. All 12 mutations in this change were killed.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
There was a problem hiding this comment.
I like the idea behind this new Matcher, but I wonder how it's meant to be used in #46, because the Refaster template methods modified in that PR don't accept any parameters: the new X() / new X<...>() constructor invocations against which we want to match are explicitly defined in the method bodies, so there's no place to put the @Matches/@NotMatches annotations? 🤔
|
That is something I ran into as well, but haven't had a super good look into it. |
|
I think we can close this PR, as the main goal of this |
Introduces a
Matcherthat matches{MethodInvocation,NewClass}Treeinstances declared with type arguments.Should unblock #46