Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap ipywidgets<8 and simplify installation directly from GitHub #10

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ankostis
Copy link

  • Discovered that the current codebase fails with ipywidgets-8.x.x, as described in Incompatible with ipywidgets >=8  #9.
  • Revamped installations instructions to work directly from GitHub
    (where the project is hosted).
  • Added a pyproject.toml file to properly build wheel out of this project
    (mute also a warning when installing directly from GitHub).

README.md Show resolved Hide resolved
Comment on lines 36 to +37
- JupyterLab 3.2.1
- ipywidgets 7.6.5
- ipywidgets 7.6.5 <8

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked for me on jupyterlab==3.6.2 and ipywidgets==7.7.4, too. But ipywidgets==8.0.5 broke it with a JavaScript error.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean augment this PR with the latest versions of the other jupyter stuff that are compatible?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess yes, it could be useful for new users to know the current latest compatible versions of other libraries so they don't spend the trouble to downgrade when not necessary.

Copy link
Author

@ankostis ankostis Mar 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really know which is the very latest version of each dependency before it breaks - we have to wait for the new releases to arrive.

What i can do, and it is actually suggested by the official docs, is to separate the setup. Py:install_requires from the requirements, txt file, and keep the capping only on the former while keeping all dependency versions in the later.

@dbsanfte
Copy link

It's been almost a year, will this ever be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants