Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap ipywidgets<8 and simplify installation directly from GitHub #10

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Cap ipywidgets<8 and simplify installation directly from GitHub #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdaaffd
FIX(deps,#9) model unregistered with ipywidgets-8+ >
ankostis Mar 21, 2023
f22e99a
fix(build) +pyproject.toml to pip install git+https
ankostis Mar 21, 2023
c25e7eb
doc(readme) install directly from github >
ankostis Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,23 @@ Thanks!

## Install
---------
- ` git clone https://github.com/johnomernik/qgrid`
In one command:

`pip install git+https://github.com/JohnOmernik/qgrid https://github.com/JohnOmernik/qgrid/raw/main/qgrid2-1.1.3-py3-none-any.whl`
ankostis marked this conversation as resolved.
Show resolved Hide resolved

..or install from sources (in develop mode with `-e`):

- `git clone https://github.com/johnomernik/qgrid --depth=1`
- `cd qgrid`
- `python setup.py install`
- `pip install -e .`
- `pip install qgrid2-1.1.3-py3-none-any.whl`
- `cd ..`

At this point, it worked for me with:

- Python 3.9
- JupyterLab 3.2.1
- ipywidgets 7.6.5
- ipywidgets 7.6.5 <8
Comment on lines 36 to +37
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked for me on jupyterlab==3.6.2 and ipywidgets==7.7.4, too. But ipywidgets==8.0.5 broke it with a JavaScript error.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean augment this PR with the latest versions of the other jupyter stuff that are compatible?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess yes, it could be useful for new users to know the current latest compatible versions of other libraries so they don't spend the trouble to downgrade when not necessary.

Copy link
Author

@ankostis ankostis Mar 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really know which is the very latest version of each dependency before it breaks - we have to wait for the new releases to arrive.

What i can do, and it is actually suggested by the official docs, is to separate the setup. Py:install_requires from the requirements, txt file, and keep the capping only on the former while keeping all dependency versions in the later.


Note: I did not require Node JS to get this working, just the commands above made it work as I prebuilt the extension.

Expand Down
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[build-system]
# Minimum requirements for the build system to execute.
requires = ["setuptools", "wheel"] # PEP 508 specifications.
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
notebook>=4.0.0
pandas>=0.18.0
ipywidgets>=7.0.0
ipywidgets>=7,<8