This repository was archived by the owner on Jan 30, 2025. It is now read-only.
PPPSYS-47023 Fix OpenAPI validation errors #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kororokke
approved these changes
Jun 20, 2024
janusz-piechota-piwik
requested review from
a team,
mrfijas and
rafalmisiarek
and removed request for
a team
mrfijas
approved these changes
Jun 20, 2024
| @@ -32,11 +32,11 @@ allOf: | |||
| description: Number of conversions. | |||
| example: 4 | |||
| last_revenue: | |||
| type: float | |||
| type: number | |||
There was a problem hiding this comment.
can it be
Suggested change
| type: number | |
| type: number | |
| format: float |
?
There was a problem hiding this comment.
If it should be a float then OK. https://swagger.io/docs/specification/data-models/data-types/#numbers
no errors |
mrfijas
approved these changes
Jun 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://piwikpro.atlassian.net/browse/PPPSYS-47023