Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

PPPSYS-47023 Fix OpenAPI validation errors #1157

Merged
merged 4 commits into from
Jun 21, 2024
Merged

PPPSYS-47023 Fix OpenAPI validation errors #1157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7335d02
PPPSYS-47023 Fix OpenAPI validation errors
janusz-piechota-piwik Jun 20, 2024
9b5e353
PPPSYS-47023 Fix OpenAPI validation errors - CR corrections
janusz-piechota-piwik Jun 20, 2024
515206c
PPPSYS-47023 Fix OpenAPI validation errors - CR corrections
janusz-piechota-piwik Jun 20, 2024
abb6bf8
PPPSYS-47023 Fix OpenAPI validation errors - CR corrections
janusz-piechota-piwik Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions audience_manager/authorized_api/definitions/profile_details.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,13 @@ allOf:
description: Number of conversions.
example: 4
last_revenue:
type: float
type: number
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it be

Suggested change
type: number
type: number
format: float

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it should be a float then OK. https://swagger.io/docs/specification/data-models/data-types/#numbers

format: float
description: Amount of last transaction.
example: 13.37
total_revenue:
type: float
type: number
format: float
description: Total amount of transactions tracked by audience manager.
example: 13.37
generic:
Expand Down
10 changes: 8 additions & 2 deletions custom_reports/http_api/definitions/query_request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,8 @@ properties:
- lte
value:
description: Value that should be matched by filter.
type: float
type: number
format: float
example: 42.5
required:
- operator
Expand Down Expand Up @@ -206,6 +207,10 @@ properties:
By default sorts descending by the first metric in query.
items:
type: array
items:
oneOf:
- type: integer
- type: string
example: [[1, "desc"], [2, "asc"]]
format:
type: string
Expand Down Expand Up @@ -233,7 +238,8 @@ properties:
Additional options for query.
properties:
sampling:
type: float
type: number
format: float
description: |
Apply sampling for query with given data percent. Sampling 0.1 means
only 10% of data are used to calculate query results. Sampling 1
Expand Down
12 changes: 9 additions & 3 deletions custom_reports/http_api/definitions/real_time_query_request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ properties:
- column_id
example: [{"column_id":"device_type"},{"column_id":"revenue","transformation_id":"sum"}]
lookback_window:
type: int
type: integer
description: |
Period of time (in minutes) to query. Example: lookback_window=10 means "last 10 minutes of data".
filters:
Expand Down Expand Up @@ -150,7 +150,8 @@ properties:
- lte
value:
description: Value that should be matched by filter.
type: float
type: number
format: float
example: 42.5
required:
- operator
Expand Down Expand Up @@ -178,6 +179,10 @@ properties:
By default sorts descending by the first metric in query.
items:
type: array
items:
oneOf:
- type: integer
- type: string
example: [[1, "desc"], [2, "asc"]]
format:
type: string
Expand Down Expand Up @@ -205,7 +210,8 @@ properties:
Additional options for query.
properties:
sampling:
type: float
type: number
format: float
description: |
Apply sampling for query with given data percent. Sampling 0.1 means
only 10% of data are used to calculate query results. Sampling 1
Expand Down
2 changes: 1 addition & 1 deletion custom_reports/http_api/paths/events.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ post:
type: array
description: List of column IDs returned.
items:
type: str
type: string
count:
type: integer
description: Total number of results available for this query.
Expand Down
1 change: 0 additions & 1 deletion custom_reports/http_api/paths/query.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ post:
description: Rows with results for the query.
items:
type: object
description:
meta:
type: object
description: Additional results metadata for the query.
Expand Down
2 changes: 1 addition & 1 deletion custom_reports/http_api/paths/real_time_events.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ post:
type: array
description: List of column IDs returned.
items:
type: str
type: string
count:
type: integer
description: Total number of results available for this query.
Expand Down
1 change: 0 additions & 1 deletion custom_reports/http_api/paths/real_time_query.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ post:
description: Rows with results for the query.
items:
type: object
description:
meta:
type: object
description: Additional results metadata for the query.
Expand Down
3 changes: 1 addition & 2 deletions custom_reports/http_api/paths/sessions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ post:
description: Rows with results for the query.
items:
type: object
description:
meta:
type: object
description: Additional results metadata for the query.
Expand All @@ -41,7 +40,7 @@ post:
type: array
description: List of column IDs returned.
items:
type: str
type: string
count:
type: integer
description: Total number of results available for this query.
Expand Down
Loading