Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling source: docs/*.md pattern #67

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

jzyinq
Copy link
Contributor

@jzyinq jzyinq commented Nov 14, 2023

In current solution such configuration:

source: docs/*.md

Would cause an error that Source file docs/*.md does not exist - obviously, this isn't a pointer to a single file but a wildcard suggesting that we're looking for set of files.

Additional check for "wildcardishness" for SourceFileMustExist validator should do the trick. I've added some test cases as a proof.

@jzyinq jzyinq requested a review from glothriel November 14, 2023 06:53
@glothriel glothriel marked this pull request as ready for review November 14, 2023 07:32
@glothriel glothriel requested a review from a team as a code owner November 14, 2023 07:32
@jzyinq jzyinq merged commit de58aa8 into master Nov 15, 2023
2 checks passed
@jzyinq jzyinq deleted the feature/ARCH-270-proper-wildcard-handling branch November 15, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants