Fix handling source: docs/*.md pattern

techdocs/script/config.py

@@ -174,6 +174,9 @@ def __init__(self, from_path, filesystem):
         self.filesystem = filesystem
 
     def validate(self, config):
+        if nodes.looks_wildcardish(config["source"]):
+            # This validator is not applicable to wildcardish paths
+            return
         if nodes.looks_fileish(config["source"]) and not self.filesystem.is_file(
             path.join(self.from_path, config["source"])
         ):
@@ -184,15 +187,17 @@ class IfSourceIsDirectoryThenDestinationMustAlsoBeDirectory(ConfigValidator):
     def validate(self, config):
         if nodes.looks_dirish(config["source"]) and not nodes.looks_dirish(config["destination"]):
             raise ConfigError(
-                f"Source is a directory but destination is not. Did you forget to add a trailing slash to desination? Offending config: {config}"
+                f"Source is a directory but destination is not. Did you forget to add a trailing slash to desination? "
+                f"Offending config: {config}"
             )
 
 
 class WildardsInTheMiddleAreApplicableOnlyToDirectories(ConfigValidator):
     def validate(self, config):
         if "*" in config["source"][:-1] and not nodes.looks_dirish(config["destination"]):
             raise ConfigError(
-                f"Putting wildcards in the middle of the pattern is only supported if the destination is a directory. Offending config: {config}"
+                f"Putting wildcards in the middle of the pattern is only supported if the destination is a directory. "
+                f"Offending config: {config}"
             )
 
 

techdocs/script/nodes.py

@@ -8,3 +8,7 @@ def looks_fileish(fspath):
 
 def looks_dirish(fspath):
     return fspath.endswith("/") or fspath.endswith("*") or fspath == "."
+
+
+def looks_wildcardish(fspath):
+    return "*" in fspath

techdocs/script/test_config.py

@@ -44,6 +44,30 @@
             },
             False,  # Absolute destination path
         ),
+        (
+            {
+                "documents": [
+                    {
+                        "project": "promil",
+                        "source": "*.md",
+                        "destination": "docs/promil/",
+                    }
+                ],
+            },
+            True,  # Wildcard for file extension
+        ),
+        (
+            {
+                "documents": [
+                    {
+                        "project": "promil",
+                        "source": "*.md",
+                        "destination": "docs/promil/test.md",
+                    }
+                ],
+            },
+            False,  # Wildcard for file extension pointing single file
+        ),
         (
             {
                 "documents": [

techdocs/script/test_copier.py

@@ -23,16 +23,30 @@ def filesystem():
                             "project": "promil",
                             "source": "docs/*",
                             "destination": "somedir/",
-                            "exclude": ["docs/internal/*"],
+                            "exclude": [
+                                "docs/internal/*",
+                                "docs/*.txt",
+                            ],
+                        },
+                        {
+                            "project": "promil",
+                            "source": "other/*.txt",
+                            "destination": "somedir/",
                         },
                     ],
                 }
             ),
             "/tmp/foo/README.md": "blabla",
             "/tmp/foo/docs/one.md": "blabla",
+            "/tmp/foo/docs/first.txt": "blabla",
+            "/tmp/foo/docs/second.txt": "blabla",
             "/tmp/foo/docs/inner/other-dir/foo.md": "blabla",
             "/tmp/foo/docs/two.md": "blabla",
             "/tmp/foo/docs/internal/int.md": "blabla",
+            "/tmp/foo/other/uno.txt": "blabla",
+            "/tmp/foo/other/due.txt": "blabla",
+            "/tmp/foo/other/non-text.md": "blabla",
+            "/tmp/foo/other/level/due.txt": "blabla",
             "/tmp/bar/projects.json": json.dumps({"promil": {"path": "docs/promil"}}),
         }
     )
@@ -56,3 +70,9 @@ def test_copier(filesystem):
     assert filesystem.is_file("/tmp/bar/docs/promil/somedir/one.md")
     assert filesystem.is_file("/tmp/bar/docs/promil/somedir/two.md")
     assert filesystem.is_file("/tmp/bar/docs/promil/somedir/inner/other-dir/foo.md")
+    assert not filesystem.is_file("/tmp/bar/docs/promil/somedir/first.txt")
+    assert not filesystem.is_file("/tmp/bar/docs/promil/somedir/second.txt")
+    assert filesystem.is_file("/tmp/bar/docs/promil/somedir/uno.txt")
+    assert filesystem.is_file("/tmp/bar/docs/promil/somedir/due.txt")
+    assert not filesystem.is_file("/tmp/bar/docs/promil/somedir/non-text.md")
+    assert not filesystem.is_file("/tmp/bar/docs/promil/somedir/level/due.txt")