Reran clang-tidy after rebase

PointCloudLibrary · Oct 13, 2023 · ae28e41 · ae28e41
1 parent d42c991
commit ae28e41
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 35 deletions.
diff --git a/recognition/include/pcl/recognition/impl/implicit_shape_model.hpp b/recognition/include/pcl/recognition/impl/implicit_shape_model.hpp
@@ -51,7 +51,7 @@
 template <typename PointT>
 pcl::features::ISMVoteList<PointT>::ISMVoteList () :
   votes_ (new pcl::PointCloud<pcl::InterestPoint> ()),
-  tree_is_valid_ (false),
+
   votes_origins_ (new pcl::PointCloud<PointT> ()),
   votes_class_ (0),
   k_ind_ (0),
@@ -297,18 +297,7 @@ pcl::features::ISMVoteList<PointT>::getNumberOfVotes ()
 }
 
 //////////////////////////////////////////////////////////////////////////////////////////////
-pcl::features::ISMModel::ISMModel () :
-  statistical_weights_ (0),
-  learned_weights_ (0),
-  classes_ (0),
-  sigmas_ (0),
-  clusters_ (0),
-  number_of_classes_ (0),
-  number_of_visual_words_ (0),
-  number_of_clusters_ (0),
-  descriptors_dimension_ (0)
-{
-}
+pcl::features::ISMModel::ISMModel () = default;
 
 //////////////////////////////////////////////////////////////////////////////////////////////
 pcl::features::ISMModel::ISMModel (ISMModel const & copy)

diff --git a/recognition/include/pcl/recognition/implicit_shape_model.h b/recognition/include/pcl/recognition/implicit_shape_model.h
@@ -187,16 +187,16 @@ namespace pcl
       ISMModel & operator = (const ISMModel& other);
 
       /** \brief Stores statistical weights. */
-      std::vector<std::vector<float> > statistical_weights_;
+      std::vector<std::vector<float> > statistical_weights_{};
 
       /** \brief Stores learned weights. */
-      std::vector<float> learned_weights_;
+      std::vector<float> learned_weights_{};
 
       /** \brief Stores the class label for every direction. */
-      std::vector<unsigned int> classes_;
+      std::vector<unsigned int> classes_{};
 
       /** \brief Stores the sigma value for each class. This values were used to compute the learned weights. */
-      std::vector<float> sigmas_;
+      std::vector<float> sigmas_{};
 
       /** \brief Stores the directions to objects center for each visual word. */
       Eigen::MatrixXf directions_to_center_;
@@ -205,7 +205,7 @@ namespace pcl
       Eigen::MatrixXf clusters_centers_;
 
       /** \brief This is an array of clusters. Each cluster stores the indices of the visual words that it contains. */
-      std::vector<std::vector<unsigned int> > clusters_;
+      std::vector<std::vector<unsigned int> > clusters_{};
 
       /** \brief Stores the number of classes. */
       unsigned int number_of_classes_{0};

diff --git a/recognition/include/pcl/recognition/linemod.h b/recognition/include/pcl/recognition/linemod.h
@@ -462,7 +462,7 @@ namespace pcl
       /** states whether to return an averaged detection */
       bool average_detections_{false};
       /** template storage */
-      std::vector<SparseQuantizedMultiModTemplate> templates_;
+      std::vector<SparseQuantizedMultiModTemplate> templates_{};
   };
 
 }
diff --git a/recognition/src/linemod.cpp b/recognition/src/linemod.cpp
@@ -48,12 +48,7 @@
 //#define LINEMOD_USE_SEPARATE_ENERGY_MAPS
 
 //////////////////////////////////////////////////////////////////////////////////////////////
-pcl::LINEMOD::LINEMOD () 
-  : template_threshold_ (0.75f)
-  , use_non_max_suppression_ (false)
-  , average_detections_ (false)
-{
-}
+pcl::LINEMOD::LINEMOD () = default;
 
 //////////////////////////////////////////////////////////////////////////////////////////////
 pcl::LINEMOD::~LINEMOD() = default;

diff --git a/search/include/pcl/search/impl/flann_search.hpp b/search/include/pcl/search/impl/flann_search.hpp
@@ -76,8 +76,7 @@ pcl::search::FlannSearch<PointT, FlannDistance>::KdTreeMultiIndexCreator::create
 //////////////////////////////////////////////////////////////////////////////////////////////
 template <typename PointT, typename FlannDistance>
 pcl::search::FlannSearch<PointT, FlannDistance>::FlannSearch(bool sorted, FlannIndexCreatorPtr creator) : pcl::search::Search<PointT> ("FlannSearch",sorted),
-  index_(), creator_ (creator), input_copied_for_flann_ (false), point_representation_ (new DefaultPointRepresentation<PointT>),
-  identity_mapping_()
+  index_(), creator_ (creator),  point_representation_ (new DefaultPointRepresentation<PointT>)
 {
   dim_ = point_representation_->getNumberOfDimensions ();
 }

diff --git a/test/common/test_transforms.cpp b/test/common/test_transforms.cpp
@@ -61,10 +61,7 @@ class Transforms : public ::testing::Test
 {
  public:
   using Scalar = typename Transform::Scalar;
-
   Transforms ()
-  : ABS_ERROR (std::numeric_limits<Scalar>::epsilon () * 10)
-  , CLOUD_SIZE (100)
   {
     Eigen::Matrix<Scalar, 6, 1> r = Eigen::Matrix<Scalar, 6, 1>::Random ();
     Eigen::Transform<Scalar, 3, Eigen::Affine> transform;
@@ -93,9 +90,8 @@ class Transforms : public ::testing::Test
       indices[i] = i * 2;
   }
 
-  const Scalar ABS_ERROR;
-  const std::size_t CLOUD_SIZE;
-
+  const Scalar ABS_ERROR{std::numeric_limits<Scalar>::epsilon () * 10};
+  const std::size_t CLOUD_SIZE{100};
   Transform tf;
 
   // Random point clouds and their expected transformed versions

diff --git a/test/octree/test_octree_iterator.cpp b/test/octree/test_octree_iterator.cpp
@@ -1467,7 +1467,6 @@ struct OctreePointCloudSierpinskiTest
   // Methods
   OctreePointCloudSierpinskiTest ()
     : oct_ (1)
-    , depth_ (7)
   {}
 
   void SetUp () override
@@ -1597,7 +1596,7 @@ struct OctreePointCloudSierpinskiTest
   // Members
   OctreeT oct_;
 
-  const unsigned depth_;
+  const unsigned depth_{7};
 };
 
 /** \brief Octree test based on a Sierpinski fractal