Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move outofcore tools to tools folder. #5606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

larshg
Copy link
Contributor

@larshg larshg commented Feb 10, 2023

No description provided.

@larshg larshg added this to the pcl-1.13.1 milestone Feb 21, 2023

if(TARGET pcl_visualization)
set(srcs outofcore_viewer.cpp
../outofcore/src/visualization/camera.cpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the idea of using/referring to files in another PCL module. However, it seems like the files in outofcore/src/visualization are only used by the outofcore_viewer, and not compiled into the outofcore module library? But on the other hand, the corresponding headers in outofcore/include/pcl/outofcore/visualization are installed as if the outofcore module library contained all the stuff from the cpp files? Unfortunately I don't have any experience with outofcore, so no idea how it is supposed to be.
Moving pcl_outofcore_process and pcl_outofcore_print seems unproblematic, so that's fine by me

@larshg larshg removed this from the pcl-1.13.1 milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants