Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PCD load crashes on empty files #5855

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Fix PCD load crashes on empty files #5855

merged 4 commits into from
Oct 30, 2023

Conversation

themightyoarfish
Copy link
Contributor

addresses #5854

larshg
larshg previously approved these changes Oct 25, 2023
View reviewed changes
@themightyoarfish themightyoarfish changed the title return -1 from PCDReader::readHeader() when input file is completely empty Fix PCD load crashes on empty files Oct 25, 2023
@mvieth mvieth linked an issue Oct 27, 2023 that may be closed by this pull request
loadPCDFile() segfaults with empty file #5854
Closed
mvieth
mvieth reviewed Oct 27, 2023
View reviewed changes
@themightyoarfish
Copy link
Contributor Author

It appears that this change breaks some tests.

mvieth
mvieth approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It appears that this change breaks some tests.

It was just a randomly failing test, not caused by your changes. I re-ran the test, now it succeeded.

@mvieth mvieth added module: io changelog: fix Meta-information for changelog generation labels Oct 28, 2023
@larshg larshg merged commit 81b92a5 into PointCloudLibrary:master Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larshg larshg larshg approved these changes

@mvieth mvieth mvieth approved these changes

Assignees
No one assigned
Labels
changelog: fix Meta-information for changelog generation module: io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loadPCDFile() segfaults with empty file
3 participants
@themightyoarfish @larshg @mvieth