VoxelGridOcclusionEstimation: fix behaviour if sensor origin is inside the voxel grid #5867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvieth
added
module: filters
changelog: fix
|
I can confirm that it now works on the sample cloud, although the viewer application is quite slow on it. |
Yes, I also noticed that. Apparently, VTK takes quite some time to generate and show all the boxes. The second commit in this PR should at least improve the processing time a bit: Instead of drawing one box per point in the input cloud (meaning that very often the same box will be drawn multiple times), the viewer now draws only one box per occupied voxel. |
- call Update() on vtk classes, otherwise the shown window is empty - use the filtered cloud instead of whole input cloud, otherwise processing is very slow for larger clouds - use the fixed RenderWindowInteractor
mvieth
force-pushed
the
voxel_grid_occlusion_estimation
branch
from
3d88342 to
190ae41
Compare
larshg
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5858