Enable USE_UMFPACK in surface module on macOS CI #6078
Conversation
cybaol
force-pushed
the
enable-USE_UMFPACK-on-macos-ci
branch
from
964462d to
bdc9ab5
Compare
CMakeLists.txt
Outdated
| @@ -293,6 +293,13 @@ endif() | |||
| # OpenMP (optional) | |||
| option(WITH_OPENMP "Build with parallelization using OpenMP" TRUE) | |||
| if(WITH_OPENMP) | |||
| if(APPLE) | |||
There was a problem hiding this comment.
Can you remove this change from this PR?
There was a problem hiding this comment.
What if you try remove the local findOpenMP and use the one from Cmake itself, as in #6100?
| else | ||
| leaf_count += node->m_count; | ||
| } | ||
| // static void NodeCountHelper( const ON_RTreeNode* node, std::size_t& node_count, std::size_t& wasted_branch_count, std::size_t& leaf_count ) |
There was a problem hiding this comment.
Lets just remove this, if you think its not of use?
cybaol
force-pushed
the
enable-USE_UMFPACK-on-macos-ci
branch
from
bdc9ab5 to
8b7c3de
Compare
No, I just found USE_UMFPACK is false in surface/on_nurbs(see https://github.com/PointCloudLibrary/pcl/blob/master/surface/src/on_nurbs/on_nurbs.cmake#L50). And didn't bother to build it in any of the other CIs. But, I've found that MacOS's stricter code checking has led to a lot of compilation errors in third-party opennurbs library. So I fixed it. |
No description provided.