[openNURBS] Update optimizer workaround condition from upstream #6154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Hi, so the main difference is that with this PR, there is no upper MSVC version for which optimizations are not turned off any more. On the one hand this is reasonable because we do not actually know right now when the problem will be fixed in MSVC, but on the other hand we would have to remember to come back to this file and set the upper version in the future. |
|
I don't have any strong opinion - but I think I would just leave it as is. Then we at least get "reminders" whenever one update Visual Studio. |
|
What about plus 10, just like #5463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport condition from upstream https://github.com/mcneel/opennurbs/blob/v8.12.24282.07001/opennurbs_lookup.cpp#L742-L743
And update workaround condition before _MSC_VER 1950
Related