Refactor Polynomials: Extract Method to Introduce RootFinder Factory Method and Tighten Encapsulation #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s roots in order.
…lgorithm with the desired precision.
…(in this case the test) needs.
…he coefficients correspond to.
hemalvarambhia
changed the title
hemalvarambhia
commented
Dec 24, 2023
Ducasse
reviewed
Dec 25, 2023
| @@ -26,6 +26,15 @@ PMPolynomial class >> coefficients: anArray [ | |||
| ^self new initialize: anArray reverse | |||
| ] | |||
|
|
|||
| { #category : #information } | |||
There was a problem hiding this comment.
I'm not sure I would put this method on the class side but I could understand.
Now why the PMNewtonZeroFinder does not define a creation class method desiredPrecision: like that you do not need this method and the class PMNewtonZeroFinder gets improved.
There was a problem hiding this comment.
Yes, I had to take smaller steps in order to keep our tests green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another test might be to test roots that are in the Complex plane.