Refactor Polynomials: Extract Method to Introduce RootFinder Factory Method and Tighten Encapsulation#322

Merged

Ducasse merged 20 commits intomasterfrom refactor-polynomials-tests

Dec 25, 2023

+59-16

Commits on Dec 24, 2023

refactor: using Parallel Change, introduced a new message that returns roots in order.
hemalvarambhia
committed
refactor: migrated the client to no longer use roots message.
hemalvarambhia
committed
refactor: Extract Method where a method instantiates a root finding algorithm with the desired precision.
hemalvarambhia
committed
refactor: made the method a class method. Next we can inline the instance method.
hemalvarambhia
committed
refactor: Move Method to a more sensible place.
hemalvarambhia
committed
refactor: Inline Method, as it has no clients.
hemalvarambhia
committed
refactor: clarified the name of the method.
hemalvarambhia
committed
style: corrected a Smalltalk code critique.
hemalvarambhia
committed
refactor: Inline Method as it has no clients.
hemalvarambhia
committed
refactor: Rename Method, and now we have the interface that a client (in this case the test) needs.
hemalvarambhia
committed
style: removed redundant comment.
hemalvarambhia
committed
refactor: Rename Variable - it looks like it is a root.
hemalvarambhia
committed
test: added a simple test for x^2 + 2x + 1, whose roots are x = -1 and -1
hemalvarambhia
committed
test: changed the example and added a comment to make it clear what the coefficients correspond to.
hemalvarambhia
committed
test: added some interesting and missing tests.
hemalvarambhia
committed
fix: corrected the comment.
hemalvarambhia
committed
test: clarified naming using domain language (repeated roots).
hemalvarambhia
committed
fix: corrected a comment.
hemalvarambhia
committed
test: clarified the name of a test.
hemalvarambhia
committed
refactor: Rename Variable where we make the roles of the objects clearer in the tests.
hemalvarambhia
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor Polynomials: Extract Method to Introduce RootFinder Factory Method and Tighten Encapsulation#322

Commits on Dec 24, 2023

refactor: using Parallel Change, introduced a new message that returns roots in order.

refactor: migrated the client to no longer use roots message.

refactor: Extract Method where a method instantiates a root finding algorithm with the desired precision.

refactor: made the method a class method. Next we can inline the instance method.

refactor: Move Method to a more sensible place.

refactor: Inline Method, as it has no clients.

refactor: clarified the name of the method.

style: corrected a Smalltalk code critique.

refactor: Inline Method as it has no clients.

refactor: Rename Method, and now we have the interface that a client (in this case the test) needs.

style: removed redundant comment.

refactor: Rename Variable - it looks like it is a root.

test: added a simple test for x^2 + 2x + 1, whose roots are x = -1 and -1

test: changed the example and added a comment to make it clear what the coefficients correspond to.

test: added some interesting and missing tests.

fix: corrected the comment.

test: clarified naming using domain language (repeated roots).

fix: corrected a comment.

test: clarified the name of a test.

refactor: Rename Variable where we make the roles of the objects clearer in the tests.