Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate feature flag poller to PostHog client (2/4) #55

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

miguelhrocha
Copy link

@miguelhrocha miguelhrocha commented Jun 2, 2024

This PR is meant to be reviewed after: #54

This change uses the changes introduced by #54 and adds them to the PostHog.java main file.

Notable changes

  • The HttpSender was renamed to HttpInteractor. It felt weird to have a class named Sender that also gets. This class implements both the Sender interface and the Getter interface.
  • The PostHog client will automatically start the featureFlagPoller if a personalApiToken is provided.

Not-implemented

Because time is limited, this is what needs to be implemented as a follow-up:

  • The PostHog client should send FeatureFlag events.
  • The PostHog client should have a customizable flag to turn on and off the local evaluation.

@miguelhrocha miguelhrocha changed the title Consume feature flag poller feat: integrate feature flag poller to PostHog client Jun 2, 2024
@miguelhrocha miguelhrocha changed the title feat: integrate feature flag poller to PostHog client feat: integrate feature flag poller to PostHog client (2/2) Jun 2, 2024
@miguelhrocha miguelhrocha changed the title feat: integrate feature flag poller to PostHog client (2/2) feat: integrate feature flag poller to PostHog client (2/3) Jun 2, 2024
@miguelhrocha miguelhrocha changed the title feat: integrate feature flag poller to PostHog client (2/3) feat: integrate feature flag poller to PostHog client (2/4) Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant