-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logo size #606
Fix logo size #606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
If we limit the height, maybe we also need to do the same for the width ?
Like max-width: 150px;
?
Yes, but from my experience it should be around 250px |
Hi @boherm Thank you for your PR, currently I tested it and, yes, the logo is a little bit smaller but I think it's not enought as you can see : FYI : you can scroll under the logo Can you correct it ? Waiting for your feedback |
Hi @AureRita, thanks for the review! This is only on the homepage or on a specific page? It looks like you haven't properly rebuild hummingbird theme or don't clear the browser cache. 🤔 @SharakPL, @tblivet, |
c0ca389
to
46bcf66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @boherm
Thank you for your PR, I tested it and it seems to works as you can see :
recording.140.webm
Tested on develop and 8.1.x
Because the PR seems to works as expected, It's QA ✔️
Thank you
we need to fix the logo size when the uploaded image is taller than longer.
--
Additional info issue from the release tests
Tested with this file :
Here's the result ❌
Screen.Recording.2024-02-23.at.15.02.30.mov