Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/snackbar add a success state #206

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Improvement/snackbar add a success state #206

merged 3 commits into from
Oct 11, 2023

Conversation

mattgoud
Copy link
Collaborator

@mattgoud mattgoud commented Oct 4, 2023

add a success state

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud mattgoud added the enhancement New feature or request label Oct 4, 2023
@mattgoud mattgoud self-assigned this Oct 4, 2023
@mattgoud mattgoud linked an issue Oct 4, 2023 that may be closed by this pull request
[Design] [Snackbar] Add a success state #205
Closed
7 tasks
@mattgoud mattgoud requested a review from krimz October 10, 2023 13:14
@mattgoud mattgoud merged commit 7b79976 into main Oct 11, 2023
2 checks passed
@mattgoud mattgoud deleted the improvement/snackbar-add-a-success-state branch October 11, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnavarro-prestashop cnavarro-prestashop cnavarro-prestashop approved these changes

@FrancoisQtr FrancoisQtr Awaiting requested review from FrancoisQtr

@krimz krimz Awaiting requested review from krimz

Assignees

@mattgoud mattgoud

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Design] [Snackbar] Add a success state
2 participants
@mattgoud @cnavarro-prestashop