Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: related #344 - handle items count and loader btn behaviors internally #345

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

mattgoud
Copy link
Collaborator

@mattgoud mattgoud commented Jun 17, 2024

❓ Types of changes

  • handle items count internally (remove prop itemCount and retrieve items count from a computed function instead )
  • handle disabled Load More btn internally (remove loaderButtonDisabled prop )
  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud mattgoud linked an issue Jun 17, 2024 that may be closed by this pull request
@mattgoud mattgoud changed the title feat: related #344 - refacto items count (wip) feat: related #344 - handle items count and loader btn behaviors internally Jun 19, 2024
@mattgoud mattgoud marked this pull request as ready for review June 19, 2024 08:32
@mattgoud mattgoud merged commit 565a49b into main Jun 19, 2024
3 of 5 checks passed
@mattgoud mattgoud deleted the 344-pagination-loader-variant-refacto-itemcount branch June 19, 2024 08:35
@mattgoud mattgoud restored the 344-pagination-loader-variant-refacto-itemcount branch June 21, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pagination] [Loader variant] - refacto itemCount
1 participant