Shxco apache to nginx upgrade #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This error seems to be arising from issues with overwriting the python environment: |
rlskoeser
approved these changes
Oct 18, 2023
group_vars/shxco_qa/vars.yml
Outdated
Comment on lines
15
to
19
| # set passenger defaults for production; override for other environments | ||
| passenger_app_root: "/var/www/{{ app_name }}" | ||
| passenger_server_name: "shakespeareandco.princeton.edu" | ||
| passenger_startup_file: "{{ app_name }}/wsgi.py" | ||
| passenger_python: "{{ passenger_app_root }}/env/bin/python" |
There was a problem hiding this comment.
these should be set in the main shxco vars and then qa vars should override the passenger server name with the qa hostname https://test-shakespeareandco.cdh.princeton.edu/
rlskoeser
reviewed
Oct 19, 2023
playbooks/shxco_qa.yml
Outdated
| - build_npm | ||
| - run_webpack # dependency for collectstatic | ||
| - configure_logging # logging directory must exist before running django commands | ||
| - django | ||
| - solr_collection | ||
| - configure_apache | ||
| # - configure_apache |
There was a problem hiding this comment.
Suggested change
| # - configure_apache |
rlskoeser
approved these changes
Oct 19, 2023
Co-authored-by: Ryan Heuser <[email protected]>
resolves #143 Co-authored-by: Ryan Heuser <[email protected]>
Co-authored-by: Ryan Heuser <[email protected]>
rlskoeser
reviewed
Dec 12, 2023
roles/build_npm/tasks/main.yml
Outdated
Comment on lines
24
to
32
| # NOTE: upgrading nodejs with ansible snap fails, even though | ||
| # the documentation claims it should refresh when then channel changes. | ||
| # Manually run a refresh command to ensure version changes take effect, e.g.: | ||
| # sudo snap refresh node --channel=18 | ||
| # NOTE2: could add a node -v check and only refresh on mismatch | ||
|
|
||
| - name: Refresh nodejs to ensure version changes take effect | ||
| become: true | ||
| ansible.builtin.command: "snap refresh node --channel={{ node_version }}/stable" |
There was a problem hiding this comment.
@kayiwa FYI, we (@quadrismegistus and I) needed to solve the node upgrade problem (#143) and came up with a simpler solution than switching to the princeton ansible role (as previously proposed). Running the refresh command here resolves the problem, and doesn't seem to cause any problems or delay when refresh has been done. The comment above should make it clear why this is here, and if/when ansible actually runs the refresh as it claims to do this stanza can be removed.
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #148
also includes a fix for #143 and changes for #169