-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shxco apache to nginx upgrade #154
Changes from 9 commits
aebdebc
c767d37
c23041c
b5d9922
4eeefaa
4201986
3fe6548
8918692
8f854b4
a030cd8
1e17d92
e3dcacf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,14 +19,17 @@ | |
channel: "{{ node_version }}/stable" | ||
state: present | ||
when: ansible_distribution == "Ubuntu" | ||
register: snap_results | ||
|
||
# NOTE: upgrading nodejs on cdh-geniza1 failed; | ||
# was able to get it working with refresh | ||
# instead of install: | ||
# sudo snap refresh node --channel=16 | ||
# We may want to run refresh as a command, see | ||
# https://serverfault.com/a/1025300 | ||
# NOTE: upgrading nodejs with ansible snap fails, even though | ||
# the documentation claims it should refresh when then channel changes. | ||
# Manually run a refresh command to ensure version changes take effect, e.g.: | ||
# sudo snap refresh node --channel=18 | ||
# NOTE2: could add a node -v check and only refresh on mismatch | ||
|
||
- name: Refresh nodejs to ensure version changes take effect | ||
become: true | ||
ansible.builtin.command: "snap refresh node --channel={{ node_version }}/stable" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kayiwa FYI, we (@quadrismegistus and I) needed to solve the node upgrade problem (#143) and came up with a simpler solution than switching to the princeton ansible role (as previously proposed). Running the refresh command here resolves the problem, and doesn't seem to cause any problems or delay when refresh has been done. The comment above should make it clear why this is here, and if/when ansible actually runs the refresh as it claims to do this stanza can be removed. |
||
|
||
- name: install javascript dependencies with npm | ||
become: true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.