Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize and enforce dynamic registered webhooks #339

Open
3 tasks
wilwade opened this issue Aug 5, 2024 · 0 comments
Open
3 tasks

Standardize and enforce dynamic registered webhooks #339

wilwade opened this issue Aug 5, 2024 · 0 comments
Labels
account-service content-publishing-service

Comments

@wilwade
Copy link
Contributor

wilwade commented Aug 5, 2024 •
edited
Loading

Graph services has a way to register webhooks. We want to use this and remove the static webhook environment variables.

  • Standardized registration and storage of the webhooks
  • Account Service: Remove Static ENV Var and add per call webhook
  • Content Publishing: Remove Static ENV and add per call webhook

Goal: Remove static env vars that depend on other services that can do the informing at time of call
@wilwade wilwade mentioned this issue Aug 5, 2024
Closed
4 tasks
This was referenced Aug 8, 2024
Merged
Closed
Closed
Closed
mattheworris added a commit that referenced this issue Aug 9, 2024
@mattheworris
account-service should replace PROVIDER_BASE_URL with WEBHOOK_BASE_URL (
b5e7fee 
#350)

## Description
The gateway microservices that use webhooks previously used the
environment variable `PROVIDER_BASE_URL` as the webhook target server.
The `social-app-template` has adopted a new nomenclature using
`WEBHOOK_BASE_URL`. All micro services should be in sync with the
`social-app-template` and use the new nomenclature.

## Acceptance Criteria

- All microservices that use webhooks use `WEBHOOK_BASE_URL` to
provision their webhook.
  - [x] account

Follow up to remove entirely:
#339
@wilwade wilwade changed the title Use dynamic registered webhooks instead of static Standardize and enforce dynamic registered webhooks Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
account-service content-publishing-service
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wilwade