Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default Koina URL #3233

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

chambm
Copy link
Member

@chambm chambm commented Nov 21, 2024

Requested by Koina dev.

@brendanx67 Shall I cherry pick this (unless there won't be another release patch)?

Requested by Koina dev.
@brendanx67
Copy link
Contributor

Yes. Please cherry-pick to the release branch. I will make a patch release next week.

@chambm chambm added the Cherry pick to release Merging PRs to master with this will create a new PR that CPs all commits to Skyline release branch label Nov 22, 2024
M/z epsilon is still tight.
@chambm chambm merged commit b92fa3a into master Nov 25, 2024
10 checks passed
@chambm chambm deleted the Skyline/work/20241121_koina_url_change branch November 25, 2024 18:14
chambm pushed a commit that referenced this pull request Nov 25, 2024
…3238)

* changed default Koina URL (requested by Koina dev)
* relaxed Koina test RT and intensity epsilon to 1e-2 (m/z epsilon is still tight)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cherry pick to release Merging PRs to master with this will create a new PR that CPs all commits to Skyline release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants