Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: better handling of signin errors 🌱 #1173 #1176

Merged
merged 1 commit into from
Jan 31, 2024
Merged

improvement: better handling of signin errors 🌱 #1173 #1176

merged 1 commit into from
Jan 31, 2024

Conversation

olemp
Copy link
Contributor

@olemp olemp commented Jan 31, 2024 •
edited
Loading

Your checklist for this pull request

  • Make sure you are requesting to pull a feature/bugfix branch (right side).
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off our dev branch.
  • Check your code additions locally using npm run watch
  • Make sure strings/resources are added using our resource files
  • Make sure CHANGELOG.md is updated if applicable
  • Make sure Smoke tests are updated if applicable

Review checklist

  • Tested locally

Description

improvement: better handling of signin errors 🌱

image

@olemp olemp added this to the Milestone 12: Magnesium milestone Jan 31, 2024
@olemp olemp self-assigned this Jan 31, 2024
@olemp olemp marked this pull request as ready for review January 31, 2024 14:05
@auto-assign auto-assign bot requested review from damsleth and okms January 31, 2024 14:05
@olemp olemp linked an issue Jan 31, 2024 that may be closed by this pull request
Ensure enrollment messages still works in "new did" #1173
Closed
1 task
@olemp olemp merged commit eb67754 into dev Jan 31, 2024
1 of 3 checks passed
@olemp olemp deleted the issues/1173 branch January 31, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damsleth damsleth Awaiting requested review from damsleth

@okms okms Awaiting requested review from okms

Assignees

@olemp olemp

Labels
None yet
Projects
None yet
Milestone
Milestone 12: Magnesium
Development

Successfully merging this pull request may close these issues.

Ensure enrollment messages still works in "new did"
1 participant
@olemp