Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager included in user sync #1246

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Manager included in user sync #1246

merged 3 commits into from
Dec 12, 2024

Conversation

olemp
Copy link
Contributor

@olemp olemp commented Dec 12, 2024

Your checklist for this pull request

Review checklist

  • Tested locally

Review theme song

🎵 The Chainsmokers - Closer 🎵

Description

This pull request adds logic to ensure a user's manager is included during the user synchronization process. Previously, the manager property was not pulled into the sync, which caused incomplete user profiles on the platform. With this change, when users are synced from the directory source, their associated managers will now be properly included and displayed, improving overall data completeness and utility.

How to test

  1. Check out this branch locally using gh pr checkout 1246 or by pulling from the remote feature branch.
  2. Run npm run watch to compile and monitor changes.
  3. Perform a user synchronization using the updated sync feature.
  4. Verify that the manager attribute is now present and correctly populated for the synced users in the UI.
  5. Confirm that no existing user data is negatively impacted by this change.

Related issues

Closes #1246

Related discussions

None.

Related PRs

None.

Related smoke tests

  • Verify that user profiles, including manager attributes, are rendered correctly in smoke tests covering user profile display.

@olemp olemp linked an issue Dec 12, 2024 that may be closed by this pull request
1 task
@olemp olemp self-assigned this Dec 12, 2024
@olemp olemp requested review from okms, damsleth and Remi749 December 12, 2024 10:01
@olemp olemp marked this pull request as ready for review December 12, 2024 10:03
@olemp olemp merged commit 1558346 into dev Dec 12, 2024
2 checks passed
@olemp olemp deleted the olemp/issues/1244 branch December 12, 2024 10:03
@olemp
Copy link
Contributor Author

olemp commented Dec 12, 2024

I just merged this change. You can expect the updated functionality to be available in the didapp-dev environment shortly. Once the deployment completes, please test the inclusion of the manager attribute in synced user profiles. Let me know if everything works as expected or if you encounter any issues, @okms @damsleth 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include sync of Manager from AD
1 participant