-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LD-SDA Documentation #3539
base: main
Are you sure you want to change the base?
LD-SDA Documentation #3539
Conversation
…iefly in GDPopt documentation
…input for the LDSDA.
…ction definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Could you also please edit lines 15-19 to update the number of algorithms to four and add a citation for the LDSDA paper?
-------------------------------------------------------- | ||
|
||
The GDPopt-LDSDA solver exploits the ordered Boolean variables in the disjunctions to solve the GDP model. | ||
It requires an **exclusive OR (XOR) logical constraint** to ensure that exactly one disjunct is active in each disjunction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth noting that in its current implementation is requires an explicit LogicalConstraint
, not just the fact that the Disjunction
is declared with xor=True
, since that's a deviation from anything else in GDP-land right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the note on the documentation of the current LD-SDA requires the explicit LogicalConstraint.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3539 +/- ##
==========================================
- Coverage 88.69% 88.69% -0.01%
==========================================
Files 888 888
Lines 101886 101886
==========================================
- Hits 90365 90364 -1
- Misses 11521 11522 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary/Motivation:
This PR enhances the Pyomo Documentation by incorporating detailed instructions on utilizing the Logic-based Discrete-Steepest Descent Algorithm (LD-SDA) solver within the Generalized Disjunctive Programming optimizer (GDPopt).
It includes additional narrative content and a usage example and ensures that the LD-SDA solver class is included in the API documentation.
Changes proposed in this PR:
starting_point
,logical_constraint_list
, anddirection_norm
.~pyomo.contrib.gdpopt.ldsda.GDP_LDSDA_Solver
to the autodoc list to enable API documentation rendering.The narrative content and example were added at the bottom of
gdpopt.rst
.The autodoc entry for
GDP_LDSDA_Solver
was appended to the list of GDPopt solver classes to ensure it appears in the API reference.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: