The process '/home/runner/.cargo/bin/cargo' failed with exit code 1

Process completed with exit code 100.

The job was canceled because "beta" failed.

The operation was canceled.

The job was canceled because "beta" failed.

The operation was canceled.

error: missing documentation for a macro --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:463:1 | 463 | macro_rules! impl_trait_SinsemillaInstructions_for_MerkleChip { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for a macro --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:426:1 | 426 | macro_rules! impl_trait_CondSwapInstructions_for { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for a macro --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:412:1 | 412 | macro_rules! impl_trait_UtilitiesInstructions_for { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for a macro --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:188:1 | 188 | macro_rules! impl_trait_MerkleInstructions_for_MerkleChip { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for a macro --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:60:1 | 60 | macro_rules! impl_trait_MerkleChipProps_for_MerkleChip { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: the lint level is defined here --> halo2_gadgets/src/lib.rs:21:9 | 21 | #![deny(missing_docs)] | ^^^^^^^^^^^^

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

unresolved link to `MerkleChip`

unresolved link to `MerkleChip`

unresolved link to `MerkleConfig`

could not document `halo2_gadgets`

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

The job was canceled because "wasm32-wasi" failed.

The operation was canceled.

error: missing documentation for a macro --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:463:1 | 463 | macro_rules! impl_trait_SinsemillaInstructions_for_MerkleChip { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for a macro --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:426:1 | 426 | macro_rules! impl_trait_CondSwapInstructions_for { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for a macro --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:412:1 | 412 | macro_rules! impl_trait_UtilitiesInstructions_for { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for a macro --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:188:1 | 188 | macro_rules! impl_trait_MerkleInstructions_for_MerkleChip { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for a macro --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:60:1 | 60 | macro_rules! impl_trait_MerkleChipProps_for_MerkleChip { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: the lint level is defined here --> halo2_gadgets/src/lib.rs:21:9 | 21 | #![deny(missing_docs)] | ^^^^^^^^^^^^

error: associated function is never used: `configure_with_tag` --> halo2_gadgets/src/utilities_opt/lookup_range_check.rs:44:19 | 44 | pub(crate) fn configure_with_tag( | ^^^^^^^^^^^^^^^^^^

error: associated function is never used: `configure` --> halo2_gadgets/src/utilities/lookup_range_check.rs:78:19 | 78 | pub(crate) fn configure( | ^^^^^^^^^ | = note: `-D dead-code` implied by `-D warnings`

error: unused imports: `UtilitiesInstructions`, `cond_swap::CondSwapInstructions`, `i2lebsp` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:12:24 | 12 | use crate::utilities::{cond_swap::CondSwapInstructions, i2lebsp, UtilitiesInstructions}; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^

error: unused imports: `HashDomains`, `SinsemillaInstructions` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:9:25 | 9 | use crate::sinsemilla::{HashDomains, SinsemillaInstructions}; | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^

error: unused import: `pasta_curves::arithmetic::CurveAffine` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:7:5 | 7 | use pasta_curves::arithmetic::CurveAffine; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: unused imports: `Chip`, `Layouter`, `Value`, `plonk::Error` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:4:15 | 4 | circuit::{Chip, Layouter, Value}, | ^^^^ ^^^^^^^^ ^^^^^ 5 | plonk::Error, | ^^^^^^^^^^^^

error: unused imports: `C`, `K` --> halo2_gadgets/src/sinsemilla_opt/chip.rs:18:37 | 18 | use crate::sinsemilla::primitives::{C, K}; | ^ ^

error: unused import: `Affine` --> halo2_gadgets/src/sinsemilla_opt/chip.rs:13:28 | 13 | use pasta_curves::pallas::{Affine, Base}; | ^^^^^^

error: unused import: `crate::sinsemilla_opt::chip::SinsemillaConfigOptimized` --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:21:5 | 21 | use crate::sinsemilla_opt::chip::SinsemillaConfigOptimized; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: unused import: `crate::utilities::lookup_range_check::LookupRangeCheck` --> halo2_gadgets/src/ecc/chip.rs:31:5 | 31 | use crate::utilities::lookup_range_check::LookupRangeCheck; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: unused import: `PrimeFieldBits` --> halo2_gadgets/src/ecc/chip.rs:10:22 | 10 | use ff::{PrimeField, PrimeFieldBits}; | ^^^^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings`

error: unused imports: `UtilitiesInstructions`, `cond_swap::CondSwapInstructions`, `i2lebsp` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:12:24 | 12 | use crate::utilities::{cond_swap::CondSwapInstructions, i2lebsp, UtilitiesInstructions}; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^

error: unused import: `MerklePath` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:10:53 | 10 | use crate::sinsemilla::merkle::{MerkleInstructions, MerklePath}; | ^^^^^^^^^^

error: unused imports: `HashDomains`, `SinsemillaInstructions` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:9:25 | 9 | use crate::sinsemilla::{HashDomains, SinsemillaInstructions}; | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^

error: unused import: `pasta_curves::arithmetic::CurveAffine` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:7:5 | 7 | use pasta_curves::arithmetic::CurveAffine; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: unused imports: `Chip`, `Layouter`, `Value`, `plonk::Error` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:4:15 | 4 | circuit::{Chip, Layouter, Value}, | ^^^^ ^^^^^^^^ ^^^^^ 5 | plonk::Error, | ^^^^^^^^^^^^

error: unused imports: `C`, `K` --> halo2_gadgets/src/sinsemilla_opt/chip.rs:18:37 | 18 | use crate::sinsemilla::primitives::{C, K}; | ^ ^

error: unused import: `Affine` --> halo2_gadgets/src/sinsemilla_opt/chip.rs:13:28 | 13 | use pasta_curves::pallas::{Affine, Base}; | ^^^^^^

error: unused import: `crate::sinsemilla_opt::chip::SinsemillaConfigOptimized` --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:21:5 | 21 | use crate::sinsemilla_opt::chip::SinsemillaConfigOptimized; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: unused import: `crate::utilities::lookup_range_check::LookupRangeCheck` --> halo2_gadgets/src/ecc/chip.rs:31:5 | 31 | use crate::utilities::lookup_range_check::LookupRangeCheck; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: unused import: `PrimeFieldBits` --> halo2_gadgets/src/ecc/chip.rs:10:22 | 10 | use ff::{PrimeField, PrimeFieldBits}; | ^^^^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings`

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

The job was canceled because "stable_ubuntu-latest" failed.

The operation was canceled.

The job was canceled because "stable_ubuntu-latest" failed.

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

The job was canceled because "stable_ubuntu-latest" failed.

The operation was canceled.

The job was canceled because "stable_ubuntu-latest" failed.

The operation was canceled.

The job was canceled because "stable_ubuntu-latest" failed.

The operation was canceled.

The job was canceled because "stable_ubuntu-latest" failed.

The operation was canceled.

The job was canceled because "stable_ubuntu-latest" failed.

The operation was canceled.

The job was canceled because "stable_ubuntu-latest" failed.

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

missing documentation for a macro

The operation was canceled.

The process '/home/runner/.cargo/bin/cargo' failed with exit code 1

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

warning: an array of `Range` that is only one element --> halo2_gadgets/src/utilities.rs:407:47 | 407 | decompose(pallas::Base::random(rng), &[0..255]); | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init = note: `-W clippy::single-range-in-vec-init` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::single_range_in_vec_init)]` help: if you wanted a `Vec` that contains the entire range, try | 407 | decompose(pallas::Base::random(rng), &(0..255).collect::<std::vec::Vec<usize>>()); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ help: if you wanted an array of len 255, try | 407 | decompose(pallas::Base::random(rng), &[0; 255]); | ~~~~~~

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:127:34 | 127 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:118:34 | 118 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:103:34 | 103 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_gadgets/src/sinsemilla.rs:706:48 | 706 | ... .chain(right.into_iter()), | ^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `right` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_gadgets/src/sinsemilla.rs:705:48 | 705 | ... .chain(left.into_iter()) | ^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `left` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`

warning: use of `default` to create a unit struct --> halo2_gadgets/src/sinsemilla/primitives.rs:351:31 | 351 | let mut os_rng = OsRng::default(); | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:127:34 | 127 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:118:34 | 118 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:103:34 | 103 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon.rs:206:33 | 206 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon.rs:159:33 | 159 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:363:33 | 363 | _domain: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:257:33 | 257 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:220:33 | 220 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs:88:38 | 88 | P128Pow5T3Gen(PhantomData::default()) | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives/grain.rs:72:32 | 72 | _field: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:517:77 | 517 | let r_0 = (p[0] + config.round_constants[round + 1][0]).pow(&config.alpha); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:477:73 | 477 | let r_0 = (p[0] + config.round_constants[round][0]).pow(&config.alpha); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:451:62 | 451 | let r: Value<Vec<F>> = q.map(|q| q.map(|q| q.pow(&config.alpha))).collect(); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:256:58 | 256 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| { | __________________________________________________________^ 257 | | res.and_then(|state| { 258 | | state.full_round( 259 | | &mut region, ... | 264 | | }) 265 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:245:61 | 245 | let state = (0..config.half_partial_rounds).fold(Ok(state), |res, r| { | _____________________________________________________________^ 246 | | res.and_then(|state| { 247 | | state.partial_round( 248 | | &mut region, ... | 253 | | }) 254 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:241:58 | 241 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| { | __________________________________________________________^ 242 | | res.and_then(|state| state.full_round(&mut region, config, r, r)) 243 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `-W clippy::manual-try-fold` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:395:42 | 395 | .map(|k| k * (*H_SCALAR).pow(&[(NUM_WINDOWS - 1) as u64, 0, 0, 0]) - offset_acc); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(NUM_WINDOWS - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:390:37 | 390 | acc + (*TWO_SCALAR).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:373:68 | 373 | let scalar = k.map(|k| (k + *TWO_SCALAR) * (*H_SCALAR).pow(&[w as u64, 0, 0, 0])); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:220:45 | 220 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:217:42 | 217 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:200:53 | 200 | * C::Scalar::from(H as u64).pow(&[idx as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[idx as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:72:53 | 72 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:65:38 | 65 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:52:57 | 52 | * C::Scalar::from(H as u64).pow(&[w as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: struct `Variable` is never constructed --> halo2_gadgets/src/sha256/table16/spread_table.rs:308:20 | 308 | pub struct Variable(Column<Advice>, usize); | ^^^^^^^^ | = note: `Variable` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:414:33 | 414 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:371:33 | 371 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:328:33 | 328 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon.rs:206:33 | 206 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon.rs:159:33 | 159 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:363:33 | 363 | _domain: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:257:33 | 257 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:220:33 | 220 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives/grain.rs:72:32 | 72 | _field: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:174:22 | 174 | .zip(inv_denoms.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: this bound is already specified as the supertrait of `ExactSizeIterator` --> halo2_proofs/src/poly.rs:167:26 | 167 | inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls = note: `-W clippy::implied-bounds-in-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::implied_bounds_in_impls)]` help: try removing this bound | 167 - inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, 167 + inv_denoms: impl ExactSizeIterator<Item = F>, |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:159:14 | 159 | .zip(assigned_denominators.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:517:77 | 517 | let r_0 = (p[0] + config.round_constants[round + 1][0]).pow(&config.alpha); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:477:73 | 477 | let r_0 = (p[0] + config.round_constants[round][0]).pow(&config.alpha); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:451:62 | 451 | let r: Value<Vec<F>> = q.map(|q| q.map(|q| q.pow(&config.alpha))).collect(); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: assigning the result of `Clone::clone()` may be inefficient --> halo2_proofs/src/poly/multiopen.rs:208:17 | 208 | point_index_set = point_idx_set.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `point_index_set.clone_from(point_idx_set)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `-W clippy::assigning-clones` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::assigning_clones)]`

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:256:58 | 256 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| { | __________________________________________________________^ 257 | | res.and_then(|state| { 258 | | state.full_round( 259 | | &mut region, ... | 264 | | }) 265 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:245:61 | 245 | let state = (0..config.half_partial_rounds).fold(Ok(state), |res, r| { | _____________________________________________________________^ 246 | | res.and_then(|state| { 247 | | state.partial_round( 248 | | &mut region, ... | 253 | | }) 254 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:241:58 | 241 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| { | __________________________________________________________^ 242 | | res.and_then(|state| state.full_round(&mut region, config, r, r)) 243 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `-W clippy::manual-try-fold` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly/multiopen/prover.rs:105:58 | 105 | let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold( | ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: use of `default` to create a unit struct --> halo2_proofs/src/poly/evaluator.rs:124:36 | 124 | _evaluator: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_proofs/src/poly/evaluator.rs:78:36 | 78 | _evaluator: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`

warning: the borrowed expression implements the required traits --> halo2_proofs/src/poly/domain.rs:559:20 | 559 | let xn = x.pow(&[8, 0, 0, 0]); | ^^^^^^^^^^^^^ help: change this to: `[8, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_proofs/src/poly/domain.rs:549:38 | 549 | points.push(domain.omega.pow(&[i, 0, 0, 0])); | ^^^^^^^^^^^^^ help: change this to: `[i, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:395:42 | 395 | .map(|k| k * (*H_SCALAR).pow(&[(NUM_WINDOWS - 1) as u64, 0, 0, 0]) - offset_acc); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(NUM_WINDOWS - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:390:37 | 390 | acc + (*TWO_SCALAR).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:373:68 | 373 | let scalar = k.map(|k| (k + *TWO_SCALAR) * (*H_SCALAR).pow(&[w as u64, 0, 0, 0])); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:319:25 | 319 | / lookups 320 | | .iter() 321 | | .flat_map(move |p| p.queries(vk, x)) 322 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 319 ~ lookups 320 + .iter() 321 ~ .flat_map(move |p| p.queries(vk, x)), |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:259:25 | 259 | / lookups 260 | | .iter() 261 | | .zip(vk.cs.lookups.iter()) 262 | | .flat_map(move |(p, argument)| { ... | 275 | | }) 276 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 259 ~ lookups 260 + .iter() 261 + .zip(vk.cs.lookups.iter()) 262 + .flat_map(move |(p, argument)| { 263 + p.expressions( 264 + l_0, 265 + l_last, 266 + l_blind, 267 + argument, 268 + theta, 269 + beta, 270 + gamma, 271 + advice_evals, 272 + fixed_evals, 273 + instance_evals, 274 + ) 275 ~ }), |

warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/verifier.rs:206:24 | 206 | let xn = x.pow(&[params.n, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:707:24 | 707 | .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookups.iter().flat_map(move |p| p.open(pk, x))` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/prover.rs:599:20 | 599 | let xn = x.pow(&[params.n, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:581:28 | 581 | .chain(permutation_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:547:14 | 547 | .zip(lookup_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookup_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:546:14 | 546 | .zip(permutation_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:1261:22 | 1261 | .zip(degrees.into_iter()) | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `degrees` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:893:18 | 893 | .zip(self.constraints.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.constraints` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:220:45 | 220 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:217:42 | 217 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:200:53 | 200 | * C::Scalar::from(H as u64).pow(&[idx as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[idx as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:72:53 | 72 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:65:38 | 65 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:52:57 | 52 | * C::Scalar::from(H as u64).pow(&[w as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: associated function `configure_with_tag` is never used --> halo2_gadgets/src/utilities_opt/lookup_range_check.rs:44:19 | 32 | impl<F: PrimeFieldBits, const K: usize> LookupRangeCheckConfigOptimized<F, K> { | ----------------------------------------------------------------------------- associated function in this implementation ... 44 | pub(crate) fn configure_with_tag( | ^^^^^^^^^^^^^^^^^^

warning: associated function `configure` is never used --> halo2_gadgets/src/utilities/lookup_range_check.rs:78:19 | 66 | impl<F: PrimeFieldBits, const K: usize> LookupRangeCheckConfig<F, K> { | -------------------------------------------------------------------- associated function in this implementation ... 78 | pub(crate) fn configure( | ^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: struct `PointIndex` is never constructed --> halo2_proofs/src/plonk/circuit.rs:769:19 | 769 | pub(crate) struct PointIndex(pub usize); | ^^^^^^^^^^

warning: trait `IndexedParallelIterator` is never used --> halo2_proofs/src/multicore.rs:28:11 | 28 | pub trait IndexedParallelIterator: std::iter::Iterator {} | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: unused imports: `UtilitiesInstructions`, `cond_swap::CondSwapInstructions`, `i2lebsp` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:12:24 | 12 | use crate::utilities::{cond_swap::CondSwapInstructions, i2lebsp, UtilitiesInstructions}; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^

warning: unused imports: `HashDomains`, `SinsemillaInstructions` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:9:25 | 9 | use crate::sinsemilla::{HashDomains, SinsemillaInstructions}; | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `pasta_curves::arithmetic::CurveAffine` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:7:5 | 7 | use pasta_curves::arithmetic::CurveAffine; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused imports: `Chip`, `Layouter`, `Value`, `plonk::Error` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:4:15 | 4 | circuit::{Chip, Layouter, Value}, | ^^^^ ^^^^^^^^ ^^^^^ 5 | plonk::Error, | ^^^^^^^^^^^^

warning: unused imports: `C`, `K` --> halo2_gadgets/src/sinsemilla_opt/chip.rs:18:37 | 18 | use crate::sinsemilla::primitives::{C, K}; | ^ ^

warning: unused import: `Affine` --> halo2_gadgets/src/sinsemilla_opt/chip.rs:13:28 | 13 | use pasta_curves::pallas::{Affine, Base}; | ^^^^^^

warning: `crate` references the macro call's crate --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:371:25 | 371 | use crate::{sinsemilla::primitives::HashDomain, utilities::i2lebsp}; | ^^^^^ help: to reference the macro definition's crate, use: `$crate` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def = note: `-W clippy::crate-in-macro-def` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::crate_in_macro_def)]`

warning: unused import: `crate::sinsemilla_opt::chip::SinsemillaConfigOptimized` --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:21:5 | 21 | use crate::sinsemilla_opt::chip::SinsemillaConfigOptimized; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `crate::utilities::lookup_range_check::LookupRangeCheck` --> halo2_gadgets/src/ecc/chip.rs:31:5 | 31 | use crate::utilities::lookup_range_check::LookupRangeCheck; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `PrimeFieldBits` --> halo2_gadgets/src/ecc/chip.rs:10:22 | 10 | use ff::{PrimeField, PrimeFieldBits}; | ^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:109:13 | 109 | /// Selector assignments used for optimization pass | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 110 | selectors: vec![vec![false; n]; num_selectors], | ---------------------------------------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment

warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:107:13 | 107 | /// Pairs of cells between which we have equality constraints. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 108 | equality: vec![], | ---------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment

warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:105:13 | 105 | /// Any cells assigned outside of a region. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 106 | loose_cells: vec![], | ------------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment = note: `#[warn(unused_doc_comments)]` on by default

warning: unused imports: `ParallelIterator`, `Scope` --> halo2_proofs/src/multicore.rs:15:34 | 15 | iter::{IntoParallelIterator, ParallelIterator}, | ^^^^^^^^^^^^^^^^ 16 | join, scope, Scope, | ^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: struct `Variable` is never constructed --> halo2_proofs/tests/plonk_api.rs:26:16 | 26 | pub struct Variable(Column<Advice>, usize); | ^^^^^^^^ | = note: `Variable` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

warning: struct `Variable` is never constructed --> halo2_proofs/benches/plonk.rs:19:16 | 19 | pub struct Variable(Column<Advice>, usize); | ^^^^^^^^ | = note: `Variable` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

warning: unused imports: `UtilitiesInstructions`, `cond_swap::CondSwapInstructions`, `i2lebsp` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:12:24 | 12 | use crate::utilities::{cond_swap::CondSwapInstructions, i2lebsp, UtilitiesInstructions}; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `MerklePath` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:10:53 | 10 | use crate::sinsemilla::merkle::{MerkleInstructions, MerklePath}; | ^^^^^^^^^^

warning: unused imports: `HashDomains`, `SinsemillaInstructions` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:9:25 | 9 | use crate::sinsemilla::{HashDomains, SinsemillaInstructions}; | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `pasta_curves::arithmetic::CurveAffine` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:7:5 | 7 | use pasta_curves::arithmetic::CurveAffine; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused imports: `Chip`, `Layouter`, `Value`, `plonk::Error` --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:4:15 | 4 | circuit::{Chip, Layouter, Value}, | ^^^^ ^^^^^^^^ ^^^^^ 5 | plonk::Error, | ^^^^^^^^^^^^

warning: unused imports: `C`, `K` --> halo2_gadgets/src/sinsemilla_opt/chip.rs:18:37 | 18 | use crate::sinsemilla::primitives::{C, K}; | ^ ^

warning: unused import: `Affine` --> halo2_gadgets/src/sinsemilla_opt/chip.rs:13:28 | 13 | use pasta_curves::pallas::{Affine, Base}; | ^^^^^^

warning: `crate` references the macro call's crate --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:371:25 | 371 | use crate::{sinsemilla::primitives::HashDomain, utilities::i2lebsp}; | ^^^^^ help: to reference the macro definition's crate, use: `$crate` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def = note: `-W clippy::crate-in-macro-def` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::crate_in_macro_def)]`

warning: unused import: `crate::sinsemilla_opt::chip::SinsemillaConfigOptimized` --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:21:5 | 21 | use crate::sinsemilla_opt::chip::SinsemillaConfigOptimized; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `crate::utilities::lookup_range_check::LookupRangeCheck` --> halo2_gadgets/src/ecc/chip.rs:31:5 | 31 | use crate::utilities::lookup_range_check::LookupRangeCheck; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `PrimeFieldBits` --> halo2_gadgets/src/ecc/chip.rs:10:22 | 10 | use ff::{PrimeField, PrimeFieldBits}; | ^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:414:33 | 414 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:371:33 | 371 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:328:33 | 328 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:174:22 | 174 | .zip(inv_denoms.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: this bound is already specified as the supertrait of `ExactSizeIterator` --> halo2_proofs/src/poly.rs:167:26 | 167 | inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls = note: `-W clippy::implied-bounds-in-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::implied_bounds_in_impls)]` help: try removing this bound | 167 - inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, 167 + inv_denoms: impl ExactSizeIterator<Item = F>, |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:159:14 | 159 | .zip(assigned_denominators.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: assigning the result of `Clone::clone()` may be inefficient --> halo2_proofs/src/poly/multiopen.rs:208:17 | 208 | point_index_set = point_idx_set.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `point_index_set.clone_from(point_idx_set)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `-W clippy::assigning-clones` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::assigning_clones)]`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly/multiopen/prover.rs:105:58 | 105 | let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold( | ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: use of `default` to create a unit struct --> halo2_proofs/src/poly/evaluator.rs:124:36 | 124 | _evaluator: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_proofs/src/poly/evaluator.rs:78:36 | 78 | _evaluator: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:319:25 | 319 | / lookups 320 | | .iter() 321 | | .flat_map(move |p| p.queries(vk, x)) 322 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 319 ~ lookups 320 + .iter() 321 ~ .flat_map(move |p| p.queries(vk, x)), |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:259:25 | 259 | / lookups 260 | | .iter() 261 | | .zip(vk.cs.lookups.iter()) 262 | | .flat_map(move |(p, argument)| { ... | 275 | | }) 276 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 259 ~ lookups 260 + .iter() 261 + .zip(vk.cs.lookups.iter()) 262 + .flat_map(move |(p, argument)| { 263 + p.expressions( 264 + l_0, 265 + l_last, 266 + l_blind, 267 + argument, 268 + theta, 269 + beta, 270 + gamma, 271 + advice_evals, 272 + fixed_evals, 273 + instance_evals, 274 + ) 275 ~ }), |

warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/verifier.rs:206:24 | 206 | let xn = x.pow(&[params.n, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:707:24 | 707 | .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookups.iter().flat_map(move |p| p.open(pk, x))` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/prover.rs:599:20 | 599 | let xn = x.pow(&[params.n, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:581:28 | 581 | .chain(permutation_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:547:14 | 547 | .zip(lookup_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookup_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:546:14 | 546 | .zip(permutation_expressions.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:1261:22 | 1261 | .zip(degrees.into_iter()) | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `degrees` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:893:18 | 893 | .zip(self.constraints.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.constraints` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/13ef05e2be9862ea7b94d0b42e0b2d044b3c7f6b/library/core/src/iter/traits/iterator.rs:602:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`

warning: struct `PointIndex` is never constructed --> halo2_proofs/src/plonk/circuit.rs:769:19 | 769 | pub(crate) struct PointIndex(pub usize); | ^^^^^^^^^^

warning: trait `IndexedParallelIterator` is never used --> halo2_proofs/src/multicore.rs:28:11 | 28 | pub trait IndexedParallelIterator: std::iter::Iterator {} | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:109:13 | 109 | /// Selector assignments used for optimization pass | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 110 | selectors: vec![vec![false; n]; num_selectors], | ---------------------------------------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment

warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:107:13 | 107 | /// Pairs of cells between which we have equality constraints. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 108 | equality: vec![], | ---------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment

warning: unused doc comment --> halo2_proofs/src/dev/cost.rs:105:13 | 105 | /// Any cells assigned outside of a region. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 106 | loose_cells: vec![], | ------------------- rustdoc does not generate documentation for expression fields | = help: use `//` for a plain comment = note: `#[warn(unused_doc_comments)]` on by default

warning: unused imports: `ParallelIterator`, `Scope` --> halo2_proofs/src/multicore.rs:15:34 | 15 | iter::{IntoParallelIterator, ParallelIterator}, | ^^^^^^^^^^^^^^^^ 16 | join, scope, Scope, | ^^^^^ | = note: `#[warn(unused_imports)]` on by default

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`

unused import: `Scope`

unused doc comment

unused doc comment

unused doc comment

field `0` is never read

`halo2_proofs` (lib) generated 5 warnings (run `cargo fix --lib -p halo2_proofs` to apply 1 suggestion)

unused import: `PrimeFieldBits`

unused import: `crate::utilities::lookup_range_check::LookupRangeCheck`

unused import: `crate::sinsemilla_opt::chip::SinsemillaConfigOptimized`

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

unused import: `PrimeFieldBits`

unused import: `crate::utilities::lookup_range_check::LookupRangeCheck`

unused import: `crate::sinsemilla_opt::chip::SinsemillaConfigOptimized`

unused import: `Affine`

unused imports: `C`, `K`

unused imports: `Chip`, `Layouter`, `Value`, `plonk::Error`

unused import: `pasta_curves::arithmetic::CurveAffine`

unused imports: `HashDomains`, `SinsemillaInstructions`

unused import: `MerklePath`

unused imports: `UtilitiesInstructions`, `cond_swap::CondSwapInstructions`, `i2lebsp`

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

unused import: `PrimeFieldBits`

unused import: `crate::utilities::lookup_range_check::LookupRangeCheck`

unused import: `crate::sinsemilla_opt::chip::SinsemillaConfigOptimized`

unused import: `Affine`

unused imports: `C`, `K`

unused imports: `Chip`, `Layouter`, `Value`, `plonk::Error`

unused import: `pasta_curves::arithmetic::CurveAffine`

unused imports: `HashDomains`, `SinsemillaInstructions`

unused import: `MerklePath`

unused imports: `UtilitiesInstructions`, `cond_swap::CondSwapInstructions`, `i2lebsp`

unused import: `PrimeFieldBits`

unused import: `crate::utilities::lookup_range_check::LookupRangeCheck`

unused import: `crate::sinsemilla_opt::chip::SinsemillaConfigOptimized`

unused import: `Affine`

unused imports: `C`, `K`

unused imports: `Chip`, `Layouter`, `Value`, `plonk::Error`

unused import: `pasta_curves::arithmetic::CurveAffine`

unused imports: `HashDomains`, `SinsemillaInstructions`

unused import: `MerklePath`

unused imports: `UtilitiesInstructions`, `cond_swap::CondSwapInstructions`, `i2lebsp`

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

unused import: `PrimeFieldBits`

unused import: `crate::utilities::lookup_range_check::LookupRangeCheck`

unused import: `crate::sinsemilla_opt::chip::SinsemillaConfigOptimized`

unused import: `Affine`

unused imports: `C`, `K`

unused imports: `Chip`, `Layouter`, `Value`, `plonk::Error`

unused import: `pasta_curves::arithmetic::CurveAffine`

unused imports: `HashDomains`, `SinsemillaInstructions`

unused import: `MerklePath`

unused imports: `UtilitiesInstructions`, `cond_swap::CondSwapInstructions`, `i2lebsp`

unused import: `PrimeFieldBits`

unused import: `crate::utilities::lookup_range_check::LookupRangeCheck`

unused import: `crate::sinsemilla_opt::chip::SinsemillaConfigOptimized`

unused import: `Affine`

unused imports: `C`, `K`

unused imports: `Chip`, `Layouter`, `Value`, `plonk::Error`

unused import: `pasta_curves::arithmetic::CurveAffine`

unused imports: `HashDomains`, `SinsemillaInstructions`

unused import: `MerklePath`

unused imports: `UtilitiesInstructions`, `cond_swap::CondSwapInstructions`, `i2lebsp`

unused import: `PrimeFieldBits`

unused import: `crate::utilities::lookup_range_check::LookupRangeCheck`

unused import: `crate::sinsemilla_opt::chip::SinsemillaConfigOptimized`

unused import: `Affine`

unused imports: `C`, `K`

unused imports: `Chip`, `Layouter`, `Value`, `plonk::Error`

unused import: `pasta_curves::arithmetic::CurveAffine`

unused imports: `HashDomains`, `SinsemillaInstructions`

unused import: `MerklePath`

unused imports: `UtilitiesInstructions`, `cond_swap::CondSwapInstructions`, `i2lebsp`

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/