Skip to content

hash_to_point simplification #280

hash_to_point simplification

hash_to_point simplification #280

GitHub Actions / Clippy (MSRV) failed Apr 22, 2024 in 0s

Clippy (MSRV)

26 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 26
Warning 0
Note 0
Help 0

Versions

  • rustc 1.60.0 (7737e0b5c 2022-04-04)
  • cargo 1.60.0 (d1fd9fe 2022-03-01)
  • clippy 0.1.60 (7737e0b 2022-04-04)

Annotations

Check failure on line 463 in halo2_gadgets/src/sinsemilla/merkle/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

missing documentation for a macro

error: missing documentation for a macro
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:463:1
    |
463 | macro_rules! impl_trait_SinsemillaInstructions_for_MerkleChip {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 426 in halo2_gadgets/src/sinsemilla/merkle/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

missing documentation for a macro

error: missing documentation for a macro
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:426:1
    |
426 | macro_rules! impl_trait_CondSwapInstructions_for {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 412 in halo2_gadgets/src/sinsemilla/merkle/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

missing documentation for a macro

error: missing documentation for a macro
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:412:1
    |
412 | macro_rules! impl_trait_UtilitiesInstructions_for {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 188 in halo2_gadgets/src/sinsemilla/merkle/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

missing documentation for a macro

error: missing documentation for a macro
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:188:1
    |
188 | macro_rules! impl_trait_MerkleInstructions_for_MerkleChip {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 60 in halo2_gadgets/src/sinsemilla/merkle/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

missing documentation for a macro

error: missing documentation for a macro
  --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:60:1
   |
60 | macro_rules! impl_trait_MerkleChipProps_for_MerkleChip {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: the lint level is defined here
  --> halo2_gadgets/src/lib.rs:21:9
   |
21 | #![deny(missing_docs)]
   |         ^^^^^^^^^^^^

Check failure on line 44 in halo2_gadgets/src/utilities_opt/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

associated function is never used: `configure_with_tag`

error: associated function is never used: `configure_with_tag`
  --> halo2_gadgets/src/utilities_opt/lookup_range_check.rs:44:19
   |
44 |     pub(crate) fn configure_with_tag(
   |                   ^^^^^^^^^^^^^^^^^^

Check failure on line 78 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

associated function is never used: `configure`

error: associated function is never used: `configure`
  --> halo2_gadgets/src/utilities/lookup_range_check.rs:78:19
   |
78 |     pub(crate) fn configure(
   |                   ^^^^^^^^^
   |
   = note: `-D dead-code` implied by `-D warnings`

Check failure on line 12 in halo2_gadgets/src/sinsemilla_opt/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused imports: `UtilitiesInstructions`, `cond_swap::CondSwapInstructions`, `i2lebsp`

error: unused imports: `UtilitiesInstructions`, `cond_swap::CondSwapInstructions`, `i2lebsp`
  --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:12:24
   |
12 | use crate::utilities::{cond_swap::CondSwapInstructions, i2lebsp, UtilitiesInstructions};
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  ^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^

Check failure on line 9 in halo2_gadgets/src/sinsemilla_opt/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused imports: `HashDomains`, `SinsemillaInstructions`

error: unused imports: `HashDomains`, `SinsemillaInstructions`
 --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:9:25
  |
9 | use crate::sinsemilla::{HashDomains, SinsemillaInstructions};
  |                         ^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 7 in halo2_gadgets/src/sinsemilla_opt/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused import: `pasta_curves::arithmetic::CurveAffine`

error: unused import: `pasta_curves::arithmetic::CurveAffine`
 --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:7:5
  |
7 | use pasta_curves::arithmetic::CurveAffine;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 4 in halo2_gadgets/src/sinsemilla_opt/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused imports: `Chip`, `Layouter`, `Value`, `plonk::Error`

error: unused imports: `Chip`, `Layouter`, `Value`, `plonk::Error`
 --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:4:15
  |
4 |     circuit::{Chip, Layouter, Value},
  |               ^^^^  ^^^^^^^^  ^^^^^
5 |     plonk::Error,
  |     ^^^^^^^^^^^^

Check failure on line 18 in halo2_gadgets/src/sinsemilla_opt/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused imports: `C`, `K`

error: unused imports: `C`, `K`
  --> halo2_gadgets/src/sinsemilla_opt/chip.rs:18:37
   |
18 | use crate::sinsemilla::primitives::{C, K};
   |                                     ^  ^

Check failure on line 13 in halo2_gadgets/src/sinsemilla_opt/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused import: `Affine`

error: unused import: `Affine`
  --> halo2_gadgets/src/sinsemilla_opt/chip.rs:13:28
   |
13 | use pasta_curves::pallas::{Affine, Base};
   |                            ^^^^^^

Check failure on line 21 in halo2_gadgets/src/sinsemilla/merkle/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused import: `crate::sinsemilla_opt::chip::SinsemillaConfigOptimized`

error: unused import: `crate::sinsemilla_opt::chip::SinsemillaConfigOptimized`
  --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:21:5
   |
21 | use crate::sinsemilla_opt::chip::SinsemillaConfigOptimized;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 31 in halo2_gadgets/src/ecc/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused import: `crate::utilities::lookup_range_check::LookupRangeCheck`

error: unused import: `crate::utilities::lookup_range_check::LookupRangeCheck`
  --> halo2_gadgets/src/ecc/chip.rs:31:5
   |
31 | use crate::utilities::lookup_range_check::LookupRangeCheck;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 10 in halo2_gadgets/src/ecc/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused import: `PrimeFieldBits`

error: unused import: `PrimeFieldBits`
  --> halo2_gadgets/src/ecc/chip.rs:10:22
   |
10 | use ff::{PrimeField, PrimeFieldBits};
   |                      ^^^^^^^^^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`

Check failure on line 12 in halo2_gadgets/src/sinsemilla_opt/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused imports: `UtilitiesInstructions`, `cond_swap::CondSwapInstructions`, `i2lebsp`

error: unused imports: `UtilitiesInstructions`, `cond_swap::CondSwapInstructions`, `i2lebsp`
  --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:12:24
   |
12 | use crate::utilities::{cond_swap::CondSwapInstructions, i2lebsp, UtilitiesInstructions};
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  ^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^

Check failure on line 10 in halo2_gadgets/src/sinsemilla_opt/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused import: `MerklePath`

error: unused import: `MerklePath`
  --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:10:53
   |
10 | use crate::sinsemilla::merkle::{MerkleInstructions, MerklePath};
   |                                                     ^^^^^^^^^^

Check failure on line 9 in halo2_gadgets/src/sinsemilla_opt/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused imports: `HashDomains`, `SinsemillaInstructions`

error: unused imports: `HashDomains`, `SinsemillaInstructions`
 --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:9:25
  |
9 | use crate::sinsemilla::{HashDomains, SinsemillaInstructions};
  |                         ^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 7 in halo2_gadgets/src/sinsemilla_opt/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused import: `pasta_curves::arithmetic::CurveAffine`

error: unused import: `pasta_curves::arithmetic::CurveAffine`
 --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:7:5
  |
7 | use pasta_curves::arithmetic::CurveAffine;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 4 in halo2_gadgets/src/sinsemilla_opt/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused imports: `Chip`, `Layouter`, `Value`, `plonk::Error`

error: unused imports: `Chip`, `Layouter`, `Value`, `plonk::Error`
 --> halo2_gadgets/src/sinsemilla_opt/merkle.rs:4:15
  |
4 |     circuit::{Chip, Layouter, Value},
  |               ^^^^  ^^^^^^^^  ^^^^^
5 |     plonk::Error,
  |     ^^^^^^^^^^^^

Check failure on line 18 in halo2_gadgets/src/sinsemilla_opt/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused imports: `C`, `K`

error: unused imports: `C`, `K`
  --> halo2_gadgets/src/sinsemilla_opt/chip.rs:18:37
   |
18 | use crate::sinsemilla::primitives::{C, K};
   |                                     ^  ^

Check failure on line 13 in halo2_gadgets/src/sinsemilla_opt/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused import: `Affine`

error: unused import: `Affine`
  --> halo2_gadgets/src/sinsemilla_opt/chip.rs:13:28
   |
13 | use pasta_curves::pallas::{Affine, Base};
   |                            ^^^^^^

Check failure on line 21 in halo2_gadgets/src/sinsemilla/merkle/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused import: `crate::sinsemilla_opt::chip::SinsemillaConfigOptimized`

error: unused import: `crate::sinsemilla_opt::chip::SinsemillaConfigOptimized`
  --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:21:5
   |
21 | use crate::sinsemilla_opt::chip::SinsemillaConfigOptimized;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 31 in halo2_gadgets/src/ecc/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused import: `crate::utilities::lookup_range_check::LookupRangeCheck`

error: unused import: `crate::utilities::lookup_range_check::LookupRangeCheck`
  --> halo2_gadgets/src/ecc/chip.rs:31:5
   |
31 | use crate::utilities::lookup_range_check::LookupRangeCheck;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^